Allow user to save incomplete or invalid configurations.

Author: jschroeder-avi

src/main/java/com/codedx/bambooplugin/CodeDxScanTask.java

@@ -18,6 +18,8 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.net.MalformedURLException;
+import java.net.URL;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.ArrayList;
@@ -117,7 +119,12 @@ private static Boolean loadUserPreferences(ScanTaskState state) {
         state.analysisName = config.get("analysisName");
         state.includePaths = config.get("includePaths");
         state.excludePaths = config.get("excludePaths");
-        state.projectId = Integer.parseInt(config.get("selectedProjectId"));
+        try {
+            state.projectId = Integer.parseInt(config.get("selectedProjectId"));
+        } catch (NumberFormatException e) {
+            logError(state, "No project selected.  Please select a Code Dx project on the task configuration page.");
+            return false;
+        }
         state.toolOutputFiles = config.get("toolOutputFiles");
         state.reportArchiveName = config.get("reportArchiveName");
         state.waitForResults = config.getAsBoolean("waitForResults");
@@ -133,16 +140,44 @@ private static Boolean loadUserPreferences(ScanTaskState state) {
             state.apiUrl = ServerConfigManager.getUrl();
             state.apiKey = ServerConfigManager.getApiKey();
             state.fingerprint = ServerConfigManager.getFingerprint();
+
+            if (state.apiUrl == null || state.apiKey == null || state.apiUrl.isEmpty() || state.apiKey.isEmpty()) {
+                logError(state, "Code Dx url and api key are not properly configured.  Please configure them on the plug-in settings page.");
+                return false;
+            }
         } else {
             state.apiUrl = config.get("url");
             state.apiKey = config.get("apiKey");
             state.fingerprint = config.get("fingerprint");
+
+            if (state.apiUrl == null || state.apiUrl.isEmpty()) {
+                logError(state, "Missing Code Dx url.  Please configure it on the task configuration page.");
+                return false;
+            } else {
+                try {
+                    new URL(state.apiUrl);
+                } catch (MalformedURLException e) {
+                    logError(state, "Malformed Code Dx url.  Please correct it on the task configuration page.");
+                    return false;
+                }
+            }
+
+            if (state.apiKey == null || state.apiKey.isEmpty()) {
+                logError(state, "Missing Code Dx api key.  Please configure it on the task configuration page.");
+                return false;
+            }
         }
 
-        if (state.apiUrl == null || state.apiKey == null || state.apiUrl.isEmpty() || state.apiKey.isEmpty()) {
-            logError(state, "Code Dx url and api key are not properly configured.  Please configure them on the plug-in settings page.");
+        if (state.analysisName == null || state.analysisName.isEmpty()) {
+            logError(state, "Missing Code Dx Analysis Name.  Please configure it on the task configuration page.");
             return false;
         }
+
+        if (state.includePaths == null || state.includePaths.isEmpty()) {
+            logError(state, "Missing source and binary files.  Please configure the field on the task configuration page.");
+            return false;
+        }
+
         log(state, "Code Dx url set to %s", state.apiUrl);
 
         return true;

src/main/java/com/codedx/bambooplugin/CodeDxScanTaskConfigurator.java

@@ -19,6 +19,9 @@
 
 public class CodeDxScanTaskConfigurator extends AbstractTaskConfigurator {
 
+    // Since much work was done surrounding saving invalid configs, lets keep the code and toggle it with a flag.
+    private static final boolean ALLOW_SAVE_INVALID_CONFIG = true;
+
     private static final Severity[] severities = Severity.all;
 
     // Tracks if we are going into an edit after a failed save attempt and remembers the credentials the user put in
@@ -84,6 +87,10 @@ public void validate(final ActionParametersMap params, final ErrorCollection err
 
         super.validate(params, errorCollection);
 
+        if (ALLOW_SAVE_INVALID_CONFIG) {
+            return;
+        }
+
         // Will be set back to false in generateTaskConfigMap(...) if save succeeds
         this.failedSave = new FailedCredentials(params);