Skip to content

Commit ea9a7fa

Browse files
Log exception on ApiException in task run
1 parent 81bcc7b commit ea9a7fa

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

src/main/java/com/codedx/bambooplugin/CodeDxScanTask.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ private static Boolean uploadFiles(ScanTaskState state) {
253253
}
254254

255255
} catch (ApiException e) {
256-
logApiException(state);
256+
logApiException(state, e);
257257
return false;
258258
} catch (IOException e) {
259259
logError(state, "An error occurred while trying to archive source files");
@@ -280,7 +280,7 @@ private static Boolean waitForCodeDxToBeReadyForAnalysis(ScanTaskState state) {
280280
try {
281281
response = state.analysisApi.queryAnalysisPrepState(state.analysisPrepId);
282282
} catch (ApiException e) {
283-
logApiException(state);
283+
logApiException(state, e);
284284
return false;
285285
}
286286

@@ -347,7 +347,7 @@ private static Boolean startAnalysis(ScanTaskState state) {
347347
}
348348
state.analysisJobId = analysis.getJobId();
349349
} catch (ApiException e) {
350-
logApiException(state);
350+
logApiException(state, e);
351351
return false;
352352
}
353353

@@ -390,7 +390,7 @@ private static Boolean waitForAnalysisToFinish(ScanTaskState state) {
390390
try {
391391
job = state.jobsApi.getJobStatus(state.analysisJobId);
392392
} catch (ApiException e) {
393-
logApiException(state);
393+
logApiException(state, e);
394394
return false;
395395
}
396396

@@ -446,7 +446,7 @@ private static Boolean getGroupedCounts(ScanTaskState state) {
446446
try {
447447
state.groupedCounts = state.findingDataApi.getFindingsGroupCount(state.projectId, request);
448448
} catch (ApiException e) {
449-
logApiException(state);
449+
logApiException(state, e);
450450
return false;
451451
}
452452
} else {
@@ -521,7 +521,7 @@ private static CodeDxBuildStatistics getBuildStats(ScanTaskState state) {
521521
List<GroupedCount> statusGroupedCounts = state.findingDataApi.getFindingsGroupCount(state.projectId, byStatus);
522522
stats = new CodeDxBuildStatistics(severityGroupedCounts, statusGroupedCounts);
523523
} catch (ApiException e) {
524-
logApiException(state);
524+
logApiException(state, e);
525525
}
526526

527527
return stats;
@@ -535,7 +535,7 @@ private static void logError(ScanTaskState state, String format, Object... args)
535535
state.buildLogger.addErrorLogEntry(String.format(format, args));
536536
}
537537

538-
private static void logApiException(ScanTaskState state) {
539-
logError(state, CodeDxConstants.API_ERROR_MESSAGE);
538+
private static void logApiException(ScanTaskState state, Exception e) {
539+
logError(state, "An error occurred while trying to communicate with Code Dx's API: %s", e.toString());
540540
}
541541
}

src/main/java/com/codedx/bambooplugin/utils/CodeDxConstants.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,4 @@ public final class CodeDxConstants {
1818
public static final String NEW = "New";
1919
public static final String TOTAL = "Total";
2020

21-
public static final String API_ERROR_MESSAGE = "An error occurred while trying to communicate with Code Dx's API.";
2221
}

0 commit comments

Comments
 (0)