refactor: reduce PHPStan child return type baseline

Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>

Author: memleakd

system/Database/BasePreparedQuery.php

@@ -192,7 +192,7 @@ abstract public function _execute(array $data): bool;
     /**
      * Returns the result object for the prepared query.
      *
-     * @return object|resource|null
+     * @return false|object|resource|null
      */
     abstract public function _getResult();
 

system/Database/ConnectionInterface.php

@@ -78,7 +78,7 @@ public function getDatabase(): string;
      * Must return this format: ['code' => string|int, 'message' => string]
      * intval(code) === 0 means "no error".
      *
-     * @return array<string, int|string>
+     * @return array{code: int|string|null, message: string|null}
      */
     public function error(): array;
 

system/Database/MySQLi/Connection.php

@@ -573,7 +573,7 @@ protected function _enableForeignKeyChecks()
      * Must return this format: ['code' => string|int, 'message' => string]
      * intval(code) === 0 means "no error".
      *
-     * @return array<string, int|string>
+     * @return array{code: int|string|null, message: string|null}
      */
     public function error(): array
     {

system/Database/OCI8/Builder.php

@@ -152,7 +152,7 @@ protected function _truncate(string $table): string
      *
      * @param mixed $where
      *
-     * @return mixed
+     * @return bool|string
      *
      * @throws DatabaseException
      */

system/Database/Postgre/Builder.php

@@ -14,7 +14,9 @@
 namespace CodeIgniter\Database\Postgre;
 
 use CodeIgniter\Database\BaseBuilder;
+use CodeIgniter\Database\BaseResult;
 use CodeIgniter\Database\Exceptions\DatabaseException;
+use CodeIgniter\Database\Query;
 use CodeIgniter\Database\RawSql;
 use CodeIgniter\Exceptions\InvalidArgumentException;
 
@@ -64,7 +66,7 @@ protected function compileIgnore(string $statement)
      *
      * @param string $direction ASC, DESC or RANDOM
      *
-     * @return BaseBuilder
+     * @return $this
      */
     public function orderBy(string $orderBy, string $direction = '', ?bool $escape = null)
     {
@@ -89,7 +91,7 @@ public function orderBy(string $orderBy, string $direction = '', ?bool $escape =
     /**
      * Increments a numeric column by the specified value.
      *
-     * @return mixed
+     * @return bool
      *
      * @throws DatabaseException
      */
@@ -111,7 +113,7 @@ public function increment(string $column, int $value = 1)
     /**
      * Decrements a numeric column by the specified value.
      *
-     * @return mixed
+     * @return bool
      *
      * @throws DatabaseException
      */
@@ -138,7 +140,7 @@ public function decrement(string $column, int $value = 1)
      *
      * @param array|null $set An associative array of insert values
      *
-     * @return mixed
+     * @return BaseResult|false|Query|string
      *
      * @throws DatabaseException
      */
@@ -225,7 +227,7 @@ protected function _insertBatch(string $table, array $keys, array $values): stri
      *
      * @param mixed $where
      *
-     * @return mixed
+     * @return bool|string
      *
      * @throws DatabaseException
      */
@@ -303,7 +305,7 @@ protected function _like_statement(?string $prefix, string $column, ?string $not
      *
      * @param RawSql|string $cond
      *
-     * @return BaseBuilder
+     * @return $this
      */
     public function join(string $table, $cond, string $type = '', ?bool $escape = null)
     {

system/Database/Postgre/Connection.php

@@ -469,7 +469,7 @@ protected function _enableForeignKeyChecks()
      * Must return this format: ['code' => string|int, 'message' => string]
      * intval(code) === 0 means "no error".
      *
-     * @return array<string, int|string>
+     * @return array{code: int|string|null, message: string|null}
      */
     public function error(): array
     {

system/Database/SQLSRV/Builder.php

@@ -14,8 +14,10 @@
 namespace CodeIgniter\Database\SQLSRV;
 
 use CodeIgniter\Database\BaseBuilder;
+use CodeIgniter\Database\BaseResult;
 use CodeIgniter\Database\Exceptions\DatabaseException;
 use CodeIgniter\Database\Exceptions\DataException;
+use CodeIgniter\Database\Query;
 use CodeIgniter\Database\RawSql;
 use CodeIgniter\Database\ResultInterface;
 use Config\Feature;
@@ -358,7 +360,7 @@ protected function _limit(string $sql, bool $offsetIgnore = false): string
     /**
      * Compiles a replace into string and runs the query
      *
-     * @return mixed
+     * @return BaseResult|false|Query|string
      *
      * @throws DatabaseException
      */
@@ -462,7 +464,7 @@ protected function _replace(string $table, array $keys, array $values): string
      *
      * Handle float return value
      *
-     * @return BaseBuilder
+     * @return $this
      */
     protected function maxMinAvgSum(string $select = '', string $alias = '', string $type = 'MAX')
     {
@@ -538,7 +540,7 @@ protected function _delete(string $table): string
      *
      * @param mixed $where
      *
-     * @return mixed
+     * @return bool|string
      *
      * @throws DatabaseException
      */

system/Database/SQLSRV/Connection.php

@@ -441,7 +441,7 @@ protected function _transRollback(): bool
      * Must return this format: ['code' => string|int, 'message' => string]
      * intval(code) === 0 means "no error".
      *
-     * @return array<string, int|string>
+     * @return array{code: int|string|null, message: string|null}
      */
     public function error(): array
     {

system/Database/SQLite3/Connection.php

@@ -428,7 +428,7 @@ protected function _enableForeignKeyChecks()
      * Must return this format: ['code' => string|int, 'message' => string]
      * intval(code) === 0 means "no error".
      *
-     * @return array<string, int|string>
+     * @return array{code: int|string|null, message: string|null}
      */
     public function error(): array
     {

system/HTTP/DownloadResponse.php

@@ -216,7 +216,7 @@ public function setStatusCode(int $code, string $reason = '')
      * Sets the Content Type header for this response with the mime type
      * and, optionally, the charset.
      *
-     * @return ResponseInterface
+     * @return $this
      */
     public function setContentType(string $mime, string $charset = 'UTF-8')
     {
@@ -286,7 +286,7 @@ public function buildHeaders()
     /**
      * output download file text.
      *
-     * @return DownloadResponse
+     * @return $this
      *
      * @throws DownloadException
      */
@@ -306,7 +306,7 @@ public function sendBody()
     /**
      * output download text by file.
      *
-     * @return DownloadResponse
+     * @return $this
      */
     private function sendBodyByFilePath()
     {
@@ -324,7 +324,7 @@ private function sendBodyByFilePath()
     /**
      * output download text by binary
      *
-     * @return DownloadResponse
+     * @return $this
      */
     private function sendBodyByBinary()
     {