Prevent closing tags after self-closing JSX tags

marijnh · marijnh · commit 2ad959e6c84a · 2024-02-20T16:56:21.000+01:00
FIX: Fix a bug that would cause self-closing JSX tags to have another closing tag inserted when typing the final '>'. Closes codemirror/dev#1339
diff --git a/src/javascript.ts b/src/javascript.ts
@@ -138,7 +138,7 @@ export const autoCloseTags = EditorView.inputHandler.of((view, from, to, text, d
       }
     } else if (text == ">") {
       let openTag = findOpenTag(around)
-      if (openTag &&
+      if (openTag && openTag.name == "JSXOpenTag" &&
           !/^\/?>|^<\//.test(state.doc.sliceString(head, head + 2)) &&
           (name = elementName(state.doc, openTag, head)))
         return {range, changes: {from: head, insert: `</${name}>`}}

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ export const autoCloseTags = EditorView.inputHandler.of((view, from, to, text, d`
`138`	`138`	`}`
`139`	`139`	`} else if (text == ">") {`
`140`	`140`	`let openTag = findOpenTag(around)`
`141`		`- if (openTag &&`
	`141`	`+ if (openTag && openTag.name == "JSXOpenTag" &&`
`142`	`142`	`!/^\/?>\|^<\//.test(state.doc.sliceString(head, head + 2)) &&`
`143`	`143`	`(name = elementName(state.doc, openTag, head)))`
`144`	`144`	return {range, changes: {from: head, insert: `</${name}>`}}