Fix a null dereference in completion

marijnh · marijnh · commit f50a084dd2d0 · 2024-05-04T08:16:57.000+02:00
FIX: Fix a null dereference in schema-based autocompletion. See https://discuss.codemirror.net/t/sql-autocomplete-object-columns-doesnt-show/7939
diff --git a/src/complete.ts b/src/complete.ts
@@ -183,7 +183,7 @@ export function completeFromSchema(schema: SQLNamespace,
     let level = top
     for (let name of parents) {
       while (!level.children || !level.children[name]) {
-        if (level == top) level = defaultSchema
+        if (level == top && defaultSchema) level = defaultSchema
         else if (level == defaultSchema && defaultTableName) level = level.child(defaultTableName)
         else return null
       }

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ export function completeFromSchema(schema: SQLNamespace,`
`183`	`183`	`let level = top`
`184`	`184`	`for (let name of parents) {`
`185`	`185`	`while (!level.children \|\| !level.children[name]) {`
`186`		`- if (level == top) level = defaultSchema`
	`186`	`+ if (level == top && defaultSchema) level = defaultSchema`
`187`	`187`	`else if (level == defaultSchema && defaultTableName) level = level.child(defaultTableName)`
`188`	`188`	`else return null`
`189`	`189`	`}`