fix(nx-fly-deployment-action): failed deployment should fail workflow

closed COD-215

Author: hakalb

packages/nx-fly-deployment-action/action.yml

@@ -84,6 +84,9 @@ outputs:
   skipped:
     description: >
       A list of project names that were skipped for some reason.
+  failed:
+    description: >
+      A list of project names that failed to deploy.
   deployed:
     description: >
       JSON object containing the deployed project names and their urls.

packages/nx-fly-deployment-action/src/lib/main.spec.ts

@@ -138,8 +138,12 @@ describe('main', () => {
         },
         { action: 'destroy', app: 'api-one-app' },
         { action: 'destroy', app: 'api-two-app' },
-        { action: 'skip', appOrProject: 'web-one', reason: 'failed' },
-        { action: 'skip', appOrProject: 'web-two', reason: 'outdated' }
+        {
+          action: 'failed',
+          appOrProject: 'web-two',
+          error: 'deployment error'
+        },
+        { action: 'skip', appOrProject: 'web-one', reason: 'outdated' }
       ]
     };
     flyDeploymentMock.mockResolvedValue(result);
@@ -154,10 +158,12 @@ describe('main', () => {
       'api-one-app',
       'api-two-app'
     ]);
-    expect(setOutputMock).toHaveBeenCalledWith('skipped', [
-      'web-one',
-      'web-two'
-    ]);
+    expect(setOutputMock).toHaveBeenCalledWith('skipped', ['web-one']);
+    expect(setOutputMock).toHaveBeenCalledWith('failed', ['web-two']);
+
+    expect(setFailedMock).toHaveBeenCalledWith(
+      'Deployment failed for 1 project(s):\nweb-two: deployment error'
+    );
   });
 
   it('should handle errors', async () => {

packages/nx-fly-deployment-action/src/lib/main.ts

@@ -54,13 +54,32 @@ export async function run(): Promise<void> {
       'skipped',
       projects.filter((p) => p.action === 'skip').map((p) => p.appOrProject)
     );
+    // Output: List of failed project names
+    core.setOutput(
+      'failed',
+      projects.filter((p) => p.action === 'failed').map((p) => p.appOrProject)
+    );
     // Output: Record of deployed project names and urls
     core.setOutput(
       'deployed',
       projects
         .filter((p) => p.action === 'deploy')
         .reduce((acc, p) => ({ ...acc, [`${p.name}`]: p.url }), {})
     );
+
+    // Fail the action if any deployments failed
+    const failedProjects = projects.filter((p) => p.action === 'failed');
+    if (failedProjects.length > 0) {
+      const failedList = failedProjects
+        .map(
+          (p) =>
+            `${p.appOrProject}: ${'error' in p ? p.error : 'Unknown error'}`
+        )
+        .join('\n');
+      core.setFailed(
+        `Deployment failed for ${failedProjects.length} project(s):\n${failedList}`
+      );
+    }
   } catch (error) {
     if (error instanceof Error) {
       core.setFailed(error.message);

packages/nx-fly-deployment-action/src/lib/schemas/action-outputs.schema.ts

@@ -1,7 +1,7 @@
 import { EnvironmentSchema } from '@codeware/core/actions';
 import { z } from 'zod';
 
-export const ActionSchema = z.enum(['deploy', 'destroy', 'skip']);
+export const ActionSchema = z.enum(['deploy', 'destroy', 'failed', 'skip']);
 
 const FlyAppNameSchema = z.object({
   app: z.string({ description: 'App name' }).min(1, 'An app name is required')
@@ -27,6 +27,17 @@ const ActionDestroySchema = FlyAppNameSchema.merge(
   })
 );
 
+// 'failed' action requires an app or project name and an error message
+const ActionFailedSchema = z.object({
+  action: z.literal(ActionSchema.enum.failed),
+  appOrProject: z
+    .string({ description: 'App or project name' })
+    .min(1, 'An app or project name is required'),
+  error: z
+    .string({ description: 'Error message' })
+    .min(1, 'An error message is required')
+});
+
 // 'skip' action requires an app or project name and a reason
 const ActionSkipSchema = z.object({
   action: z.literal(ActionSchema.enum.skip),
@@ -42,6 +53,7 @@ const ActionSkipSchema = z.object({
 const ProjectSchema = z.discriminatedUnion('action', [
   ActionDeploySchema,
   ActionDestroySchema,
+  ActionFailedSchema,
   ActionSkipSchema
 ]);
 

packages/nx-fly-deployment-action/src/lib/utils/run-deploy-apps.ts

@@ -167,14 +167,14 @@ export const runDeployApps = async (options: {
       } catch (error) {
         const msg = error instanceof Error ? error.message : String(error);
 
-        core.warning(
+        core.error(
           `[${projectName}] ❌ Failed to deploy project${tenantLabel}: ${msg}`
         );
 
         projects.push({
           appOrProject: tenantId ? `${projectName} (${tenantId})` : projectName,
-          action: 'skip',
-          reason: `Failed to deploy project${tenantLabel}`
+          action: 'failed',
+          error: msg
         });
       }
     }