Skip to content

Commit 68431ed

Browse files
committed
fix(nx-payload): let plugin user install sharp when needed
closed COD-315
1 parent 272f54b commit 68431ed

5 files changed

Lines changed: 5 additions & 17 deletions

File tree

packages/nx-payload/src/generators/application/__snapshots__/application.spec.ts.snap

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ import { fileURLToPath } from 'url';
7272
import { mongooseAdapter } from '@payloadcms/db-mongodb';
7373
import { lexicalEditor } from '@payloadcms/richtext-lexical';
7474
import { buildConfig } from 'payload';
75-
import sharp from 'sharp';
7675
7776
import { Media } from './collections/Media';
7877
import { Users } from './collections/Users';
@@ -99,8 +98,7 @@ export default buildConfig({
9998
graphQL: {
10099
disable: true,
101100
schemaOutputFile: path.resolve(dirname, 'generated', 'schema.graphql'),
102-
},
103-
sharp
101+
}
104102
});
105103
"
106104
`;
@@ -112,7 +110,6 @@ import { fileURLToPath } from 'url';
112110
import { postgresAdapter } from '@payloadcms/db-postgres';
113111
import { lexicalEditor } from '@payloadcms/richtext-lexical';
114112
import { buildConfig } from 'payload';
115-
import sharp from 'sharp';
116113
117114
import { Media } from './collections/Media';
118115
import { Users } from './collections/Users';
@@ -142,8 +139,7 @@ export default buildConfig({
142139
graphQL: {
143140
disable: true,
144141
schemaOutputFile: path.resolve(dirname, 'generated', 'schema.graphql'),
145-
},
146-
sharp
142+
}
147143
});
148144
"
149145
`;

packages/nx-payload/src/generators/application/files/src/payload.config.ts__tmpl__

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { mongooseAdapter } from '@payloadcms/db-mongodb';
66
import { postgresAdapter } from '@payloadcms/db-postgres';
77
<% } %>import { lexicalEditor } from '@payloadcms/richtext-lexical';
88
import { buildConfig } from 'payload';
9-
import sharp from 'sharp';
109

1110
import { Media } from './collections/Media';
1211
import { Users } from './collections/Users';
@@ -40,6 +39,5 @@ export default buildConfig({
4039
graphQL: {
4140
disable: true,
4241
schemaOutputFile: path.resolve(dirname, 'generated', 'schema.graphql'),
43-
},
44-
sharp
42+
}
4543
});

packages/nx-payload/src/generators/init/init.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import type { PackageJson } from 'nx/src/utils/package-json';
55
import {
66
graphqlVersion,
77
payloadVersion,
8-
sharpVersion,
98
testingLibraryDomVersion,
109
testingLibraryJestDomVersion,
1110
testingLibraryReactVersion
@@ -39,8 +38,7 @@ describe('init', () => {
3938
'@payloadcms/next': payloadVersion,
4039
'@payloadcms/richtext-lexical': payloadVersion,
4140
graphql: graphqlVersion,
42-
payload: payloadVersion,
43-
sharp: sharpVersion
41+
payload: payloadVersion
4442
},
4543
devDependencies: {
4644
'@payloadcms/graphql': payloadVersion,

packages/nx-payload/src/generators/init/libs/update-dependencies.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { type Tree, addDependenciesToPackageJson } from '@nx/devkit';
33
import {
44
graphqlVersion,
55
payloadVersion,
6-
sharpVersion,
76
testingLibraryDomVersion,
87
testingLibraryJestDomVersion,
98
testingLibraryReactVersion
@@ -25,8 +24,7 @@ export function updateDependencies(tree: Tree) {
2524
'@payloadcms/next': payloadVersion,
2625
'@payloadcms/richtext-lexical': payloadVersion,
2726
payload: payloadVersion,
28-
graphql: graphqlVersion,
29-
sharp: sharpVersion
27+
graphql: graphqlVersion
3028
},
3129
{
3230
'@payloadcms/graphql': payloadVersion,

packages/nx-payload/src/utils/versions.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ export const payloadVersion = '^3.20.0';
33

44
export const graphqlVersion = '^16.10.0';
55

6-
export const sharpVersion = '^0.33.5';
7-
86
export const testingLibraryDomVersion = '^10.0.0';
97
export const testingLibraryJestDomVersion = '^6.1.0';
108
export const testingLibraryReactVersion = '^16.1.0';

0 commit comments

Comments
 (0)