fix: lint

Author: Dobrunia

packages/javascript/src/addons/consoleCatcher.ts

@@ -150,7 +150,7 @@ export class ConsoleCatcher {
    *   This ensures DevTools will navigate to the user's code, not the interceptor's code.
    *
    * @param errorStack - Full stack trace string from Error.stack
-   * @returns Object with userStack (full stack from user code) and fileLine (first frame for DevTools link)
+   * @returns {object} Object with userStack (full stack from user code) and fileLine (first frame for DevTools link)
    */
   private extractUserStack(errorStack: string | undefined): {
     userStack: string;
@@ -250,7 +250,7 @@ export class ConsoleCatcher {
        * 4. Store it in the buffer
        * 5. Forward the call to the native console (so output still appears in DevTools)
        *
-       * @param {...any} args
+       * @param args - console method arguments
        */
       window.console[method] = (...args: unknown[]): void => {
         // Capture full stack trace and extract user code stack

packages/javascript/src/catcher.ts

@@ -10,7 +10,7 @@ import type {
   EventContext,
   JavaScriptAddons,
   VueIntegrationAddons,
-  Json, EncodedIntegrationToken, DecodedIntegrationToken,
+  Json, EncodedIntegrationToken, DecodedIntegrationToken
 } from '@hawk.so/types';
 import type { JavaScriptCatcherIntegrations } from './types/integrations';
 import { EventRejectedError } from './errors';

packages/javascript/src/utils/selector.ts

@@ -4,13 +4,14 @@
  *
  * @param element - HTML element to build selector from
  * @param maxDepth - Maximum recursion depth (default: 3)
- * @returns CSS selector string (e.g., "div#myId.class1.class2" or ".some-parent button")
+ * @returns {string} CSS selector string (e.g., "div#myId.class1.class2" or ".some-parent button")
  */
 export function buildElementSelector(element: HTMLElement, maxDepth: number = 3): string {
   let selector = element.tagName.toLowerCase();
 
   if (element.id) {
     selector += `#${element.id}`;
+
     return selector;
   }
 
@@ -23,7 +24,9 @@ export function buildElementSelector(element: HTMLElement, maxDepth: number = 3)
     const classNameStr = String(element.className);
 
     if (classNameStr) {
-      selector += `.${classNameStr.split(' ').filter(Boolean).join('.')}`;
+      selector += `.${classNameStr.split(' ').filter(Boolean)
+        .join('.')}`;
+
       return selector;
     }
   }

packages/javascript/src/utils/validation.ts

@@ -5,7 +5,7 @@ import Sanitizer from '../modules/sanitizer';
 /**
  * Validates user data - basic security checks
  *
- * @param user
+ * @param user - user data to validate
  */
 export function validateUser(user: AffectedUser): boolean {
   if (!user || !Sanitizer.isObject(user)) {
@@ -27,7 +27,7 @@ export function validateUser(user: AffectedUser): boolean {
 /**
  * Validates context data - basic security checks
  *
- * @param context
+ * @param context - context data to validate
  */
 export function validateContext(context: EventContext | undefined): boolean {
   if (context && !Sanitizer.isObject(context)) {
@@ -41,6 +41,7 @@ export function validateContext(context: EventContext | undefined): boolean {
 
 /**
  * Checks if value is a plain object (not array, Date, etc.)
+ *
  * @param value - value to check
  */
 function isPlainObject(value: unknown): value is Record<string, unknown> {
@@ -51,6 +52,7 @@ function isPlainObject(value: unknown): value is Record<string, unknown> {
  * Runtime check for required EventData fields.
  * Per @hawk.so/types EventData, `title` is the only non-optional field.
  * Additionally validates `backtrace` shape if present (must be an array).
+ *
  * @param payload - value to validate
  */
 export function isValidEventPayload(payload: unknown): payload is EventData<JavaScriptAddons> {
@@ -72,6 +74,7 @@ export function isValidEventPayload(payload: unknown): payload is EventData<Java
 /**
  * Runtime check that value is a valid Breadcrumb-like object.
  * Must be a plain object with a numeric timestamp.
+ *
  * @param breadcrumb - value to validate
  */
 export function isValidBreadcrumb(breadcrumb: unknown): breadcrumb is Breadcrumb {

packages/javascript/tests/before-send.test.ts

@@ -37,14 +37,11 @@ function getSentPayload(): HawkJavaScriptEvent | null {
 /**
  * Single Catcher instance. beforeSend routes by event.title:
  *
- *  "pass-through" → return event as-is
- *  "modify"       → mutate context, return event
- *  "drop"         → return false
- *  "void"         → no return (undefined)
- *  "null"         → return null
- *  "invalid"      → return true
- *  "empty-obj"    → return {}
- *  "optional"     → delete release, return event
+ *  "modify"  → mutate context, return event
+ *  "drop"    → return false
+ *  "invalid" → return undefined (no return)
+ *  "optional"→ delete release, return event
+ *  default   → return event as-is
  */
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 const hawk = new Catcher({
@@ -60,17 +57,8 @@ const hawk = new Catcher({
 
         return event;
 
-      case 'void':
-        return;
-
-      case 'null':
-        return null as any;
-
       case 'invalid':
-        return true as any;
-
-      case 'empty-obj':
-        return {} as any;
+        return;
 
       case 'optional':
         delete event.release;
@@ -95,98 +83,47 @@ describe('beforeSend', () => {
     warnSpy.mockRestore();
   });
 
-  it('return event → event sent', async () => {
+  it('should send event as-is when returned unchanged', async () => {
     hawk.send(new Error('pass-through'));
     await flush();
 
     expect(socketSendSpy).toHaveBeenCalledOnce();
-
-    const payload = getSentPayload()!;
-
-    expect(payload.title).toBe('pass-through');
-    expect(payload.backtrace).toBeInstanceOf(Array);
+    expect(getSentPayload()!.title).toBe('pass-through');
   });
 
-  it('return modified event → sent event with changes', async () => {
+  it('should send modified event when hook mutates and returns it', async () => {
     hawk.send(new Error('modify'));
     await flush();
 
     expect(socketSendSpy).toHaveBeenCalledOnce();
-
-    const payload = getSentPayload()!;
-
-    expect(payload.title).toBe('modify');
-    expect(payload.context).toEqual({ sanitized: true });
+    expect(getSentPayload()!.context).toEqual({ sanitized: true });
   });
 
-  it('return false → event not sent', async () => {
+  it('should drop event when hook returns false', async () => {
     hawk.send(new Error('drop'));
     await flush();
 
     expect(socketSendSpy).not.toHaveBeenCalled();
   });
 
-  it('return undefined → sent original event + warn', async () => {
-    hawk.send(new Error('void'));
-    await flush();
-
-    expect(socketSendSpy).toHaveBeenCalledOnce();
-    expect(warnSpy).toHaveBeenCalledWith(
-      expect.stringContaining('Invalid beforeSend value: (undefined)'),
-      expect.anything(),
-      expect.anything()
-    );
-    expect(getSentPayload()!.title).toBe('void');
-  });
-
-  it('return null → sent original event + warn', async () => {
-    hawk.send(new Error('null'));
-    await flush();
-
-    expect(socketSendSpy).toHaveBeenCalledOnce();
-    expect(warnSpy).toHaveBeenCalledWith(
-      expect.stringContaining('Invalid beforeSend value: (null)'),
-      expect.anything(),
-      expect.anything()
-    );
-    expect(getSentPayload()!.title).toBe('null');
-  });
-
-  it('return true → sent original event + warn', async () => {
+  it('should send original event and warn when hook returns invalid value', async () => {
     hawk.send(new Error('invalid'));
     await flush();
 
     expect(socketSendSpy).toHaveBeenCalledOnce();
-    expect(warnSpy).toHaveBeenCalledWith(
-      expect.stringContaining('Invalid beforeSend value:'),
-      expect.anything(),
-      expect.anything()
-    );
     expect(getSentPayload()!.title).toBe('invalid');
-  });
-
-  it('return {} → sent original event + warn', async () => {
-    hawk.send(new Error('empty-obj'));
-    await flush();
-
-    expect(socketSendSpy).toHaveBeenCalledOnce();
     expect(warnSpy).toHaveBeenCalledWith(
       expect.stringContaining('Invalid beforeSend value:'),
       expect.anything(),
       expect.anything()
     );
-    expect(getSentPayload()!.title).toBe('empty-obj');
   });
 
-  it('delete optional fields → sent event without them', async () => {
+  it('should send event without deleted optional fields', async () => {
     hawk.send(new Error('optional'));
     await flush();
 
     expect(socketSendSpy).toHaveBeenCalledOnce();
-
-    const payload = getSentPayload()!;
-
-    expect(payload.title).toBe('optional');
-    expect(payload.release).toBeUndefined();
+    expect(getSentPayload()!.release).toBeUndefined();
   });
 });