update(note parents): based on last review, still work on sql

Author: dependentmadani

src/presentation/http/router/note.test.ts

@@ -519,7 +519,7 @@ describe('Note API', () => {
       expect(response?.json().message).toStrictEqual(expectedMessage);
     });
 
-    test('Returns one parents note in case when note has one parents', async () => {
+    test('Returns one parents note in case when note has one parent', async () => {
       /** Create test user */
       const user = await global.db.insertUser();
 
@@ -572,7 +572,7 @@ describe('Note API', () => {
       });
     });
 
-    test('Returns two parents note in case when note has two parents', async () => {
+    test('Returns two note parents in case when note has two parents', async () => {
       /** Create test user */
       const user = await global.db.insertUser();
 
@@ -640,7 +640,7 @@ describe('Note API', () => {
       });
     });
 
-    test('Returns one parent\'s note when the user is not in the parent note\'s team but shares a relation', async () => {
+    test('Returns one parent note when the user is not in the parent note\'s team but shares a note relation', async () => {
       /** Create test user */
       const user = await global.db.insertUser();
 

src/repository/noteRelations.repository.ts

@@ -74,6 +74,6 @@ export default class NoteRelationsRepository {
    * @returns an array of note parents ids
    */
   public async getNoteParentsIds(noteId: NoteInternalId): Promise<NoteInternalId[]> {
-    return await this.storage.getAllNoteParentsIds(noteId);
+    return await this.storage.getNoteParentsIds(noteId);
   }
 }

src/repository/storage/postgres/orm/sequelize/noteRelations.ts

@@ -1,11 +1,11 @@
 import type { CreationOptional, InferAttributes, InferCreationAttributes, ModelStatic, Sequelize } from 'sequelize';
+import { QueryTypes } from 'sequelize';
 import { Op } from 'sequelize';
 import { NoteModel } from '@repository/storage/postgres/orm/sequelize/note.js';
 import type Orm from '@repository/storage/postgres/orm/sequelize/index.js';
 import type { NoteInternalId } from '@domain/entities/note.js';
 import type { Note } from '@domain/entities/note.js';
 import { Model, DataTypes } from 'sequelize';
-import { isEmpty, notEmpty } from '@infrastructure/utils/empty.js';
 
 /**
  * Class representing a note relations in database
@@ -216,29 +216,29 @@ export default class NoteRelationsSequelizeStorage {
    * where the user has access to.
    * @param noteId - the ID of the note.
    */
-  public async getAllNoteParentsIds(noteId: NoteInternalId): Promise<NoteInternalId[]> {
-    const parentNotes: NoteInternalId[] = [];
-    let currentNoteId: number | null = noteId;
+  public async getNoteParentsIds(noteId: NoteInternalId): Promise<NoteInternalId[]> {
+    let parentNotes: NoteInternalId[] = [];
 
     // get all note ids via a singe sql query instead of many
-    while (currentNoteId !== null) {
-      const noteRelation: NoteRelationsModel | null = await this.model.findOne({
-        where: {
-          noteId: currentNoteId,
-        },
-      });
-
-      if (notEmpty(noteRelation)) {
-        parentNotes.push(noteRelation.noteId);
-      }
-
-      if (isEmpty(noteRelation)) {
-        parentNotes.push(currentNoteId);
-        break;
-      } else {
-        currentNoteId = noteRelation.parentId ?? null;
-      }
-    }
+    const query = `
+      WITH RECURSIVE note_tree AS (
+        SELECT noteId, parentId
+        FROM NoteRelations
+        WHERE noteId = :startNoteId
+        UNION ALL
+        SELECT nr.noteId, nr.parentId
+        FROM NoteRelations nr
+        INNER JOIN note_tree nt ON nt.parentId = nr.noteId
+      )
+      SELECT noteId FROM note_tree;
+    `;
+
+    const result = await this.model.sequelize?.query(query, {
+      replacements: { startNoteId: noteId },
+      type: QueryTypes.SELECT,
+    });
+
+    parentNotes = (result as { noteId: number }[])?.map(note => note.noteId) ?? [];
 
     parentNotes.reverse();