Skip to content

Commit b8ae09c

Browse files
paule96paule96
committed
add vscode support
1 parent 18cee7a commit b8ae09c

4 files changed

Lines changed: 15 additions & 12 deletions

File tree

‎KK.AspNetCore.EasyAuthAuthentication.code-workspace‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
"name": "EasyAuth Middleware",
66
"path": "./src/KK.AspNetCore.EasyAuthAuthentication"
77
},
8+
{
9+
"name": "Tests",
10+
"path": "./test/KK.AspNetCore.EasyAuthAuthentication.Test"
11+
},
812
{
913
"name": "EasyAuth Middleware Sample Web",
1014
"path": "./samples/KK.AspNetCore.EasyAuthAuthentication.Samples.Web"

‎src/KK.AspNetCore.EasyAuthAuthentication/Services/EasyAuthForAuthorizationTokenService.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ private IEnumerable<AADClaimsModel> BuildFromAuthToken(JObject xMsClientPrincipa
8585
Typ = options.NameClaimType,
8686
Values = xMsClientPrincipal.ContainsKey("upn") ?
8787
xMsClientPrincipal["upn"].ToString() : // this appends if an user is using the auth token from the /.auth/me site on the website
88-
xMsClientPrincipal["appid"].ToString() // this appends if an applicaiton is try accessing the app.
88+
xMsClientPrincipal["appid"].ToString() // this appends if an application is try accessing the app.
8989
});
9090
return claims;
9191
}

‎test/KK.AspNetCore.EasyAuthAuthentication.Test/EasyAuthAuthenticationHandlerTest.cs‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,10 @@ public async Task IfAnProviderIsEnabledUseEnabledProvider()
4040
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
4141
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "RedirectToLoginPage");
4242
var configBuilder = new ConfigurationBuilder();
43-
configBuilder.AddEnvironmentVariables();
43+
_ = configBuilder.AddEnvironmentVariables();
4444
var config = configBuilder.Build();
4545
var options = new EasyAuthAuthenticationOptions();
4646
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = true });
47-
4847

4948
var services = new ServiceCollection().AddOptions()
5049
.AddSingleton<IOptionsFactory<EasyAuthAuthenticationOptions>, OptionsFactory<EasyAuthAuthenticationOptions>>()
@@ -74,7 +73,7 @@ public async Task IfAnProviderIsdisabledSkipProvider()
7473
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
7574
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "RedirectToLoginPage");
7675
var configBuilder = new ConfigurationBuilder();
77-
configBuilder.AddEnvironmentVariables();
76+
_ = configBuilder.AddEnvironmentVariables();
7877
var config = configBuilder.Build();
7978
var options = new EasyAuthAuthenticationOptions();
8079
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });
@@ -107,7 +106,7 @@ public async Task IfTheUserIsAlreadyAuthorizedTheAuthResultIsSuccess()
107106
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
108107
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "RedirectToLoginPage");
109108
var configBuilder = new ConfigurationBuilder();
110-
configBuilder.AddEnvironmentVariables();
109+
_ = configBuilder.AddEnvironmentVariables();
111110
var config = configBuilder.Build();
112111
var options = new EasyAuthAuthenticationOptions();
113112
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });
@@ -142,7 +141,7 @@ public async Task DontCallTheFallBackIfTheRequestUrlEqualsTheAuthEndPoint()
142141
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
143142
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "RedirectToLoginPage");
144143
var configBuilder = new ConfigurationBuilder();
145-
configBuilder.AddEnvironmentVariables();
144+
_ = configBuilder.AddEnvironmentVariables();
146145
var config = configBuilder.Build();
147146
var options = new EasyAuthAuthenticationOptions();
148147
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });
@@ -175,7 +174,7 @@ public async Task CallTheFallBackIfTheRequestUrlNotEqualsTheAuthEndPoint()
175174
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
176175
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "RedirectToLoginPage");
177176
var configBuilder = new ConfigurationBuilder();
178-
configBuilder.AddEnvironmentVariables();
177+
_ = configBuilder.AddEnvironmentVariables();
179178
var config = configBuilder.Build();
180179
var options = new EasyAuthAuthenticationOptions();
181180
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });
@@ -208,7 +207,7 @@ public async Task DontCallAProviderIfNotProviderIsRegistered()
208207
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
209208
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "RedirectToLoginPage");
210209
var configBuilder = new ConfigurationBuilder();
211-
configBuilder.AddEnvironmentVariables();
210+
_ = configBuilder.AddEnvironmentVariables();
212211
var config = configBuilder.Build();
213212
var options = new EasyAuthAuthenticationOptions();
214213
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });
@@ -238,7 +237,7 @@ public void ErrorIfTheAuthIsEnabledButAnonymousRequestsAreAllowed()
238237
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "True");
239238
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_UNAUTHENTICATED_ACTION", "AllowAnonymous");
240239
var configBuilder = new ConfigurationBuilder();
241-
configBuilder.AddEnvironmentVariables();
240+
_ = configBuilder.AddEnvironmentVariables();
242241
var config = configBuilder.Build();
243242
var options = new EasyAuthAuthenticationOptions();
244243
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });
@@ -250,7 +249,7 @@ public void ErrorIfTheAuthIsEnabledButAnonymousRequestsAreAllowed()
250249
.BuildServiceProvider();
251250
var monitor = services.GetRequiredService<IOptionsMonitor<EasyAuthAuthenticationOptions>>();
252251

253-
Assert.Throws<ArgumentException>(() => new EasyAuthAuthenticationHandler(monitor, new List<IEasyAuthAuthentificationService>(), this.loggerFactory, this.urlEncoder, this.clock, config));
252+
_ = Assert.Throws<ArgumentException>(() => new EasyAuthAuthenticationHandler(monitor, new List<IEasyAuthAuthentificationService>(), this.loggerFactory, this.urlEncoder, this.clock, config));
254253
}
255254

256255
[Fact]
@@ -259,7 +258,7 @@ public async Task UseEasyAuthProviderIfAuthIsDisabled()
259258
// Arrange
260259
System.Environment.SetEnvironmentVariable("APPSETTING_WEBSITE_AUTH_ENABLED", "False");
261260
var configBuilder = new ConfigurationBuilder();
262-
configBuilder.AddEnvironmentVariables();
261+
_ = configBuilder.AddEnvironmentVariables();
263262
var config = configBuilder.Build();
264263
var options = new EasyAuthAuthenticationOptions();
265264
options.AddProviderOptions(new ProviderOptions("TestProvider") { Enabled = false });

‎test/KK.AspNetCore.EasyAuthAuthentication.Test/Services/EasyAuthForAuthorizationTokenServiceTest.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void IfAValidJwtTokenWithoutIdpAndIssPropertyIsInTheHeaderItsThrowsAnErro
9494
var jwtWithoutIdpProperty = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiIwN2Q2ZDE1YS1jZTg5LTQ4MmMtOTcxYi01NDMxYjc1MTkxNjciLCJpYXQiOjE1NjI2OTg4NzYsIm5iZiI6MTU2MjY5ODg3NiwiZXhwIjoxNTYyNzAyNzc2LCJhaW8iOiI0MlpnWU9CZnNHN3RkSDVlUGlIdm81T1B0N3JPQndBPSIsImFwcGlkIjoiZDMxNWJmYWYtNjMwNC00ZjlmLTgyMWMtNTQ2YmRjMDBiNWIwIiwiYXBwaWRhY3IiOiIxIiwib2lkIjoiZjVmOWZhODYtNDQxNC00NGM3LTgwZjgtZjc4MGFlMGFiZjIxIiwicm9sZXMiOlsiU3lzdGVtQWRtaW4iXSwic3ViIjoiZjVmOWZhODYtNDQxNC00NGM3LTgwZjgtZjc4MGFlMGFiZjIxIiwidGlkIjoiZTk4MWRjYWYtOTE5Ny00NzdmLWJkMDYtMGU1NzJiMGIzMzQ3IiwidXRpIjoiaENKdTNvaDd3VWVaYWk1UUpPWUFBQSIsInZlciI6IjEuMCJ9.6hcHmq8VahVMqtvA9DJdoY-NIUjkPgMEfryGuLVJMHw";
9595
httpcontext.Request.Headers.Add("Authorization", jwtWithoutIdpProperty);
9696
// Act && Arrange
97-
Assert.Throws<ArgumentException>(() => handler.AuthUser(httpcontext));
97+
_ = Assert.Throws<ArgumentException>(() => handler.AuthUser(httpcontext));
9898
}
9999
}
100100
}

0 commit comments

Comments
 (0)