add 100% coverage for the models

Author: paule96

src/KK.AspNetCore.EasyAuthAuthentication/KK.AspNetCore.EasyAuthAuthentication.csproj

@@ -25,6 +25,7 @@
     <WarningsAsErrors>
       CS8600;CS8602;CS8603<!--The identifiers are all for nullable errors. See here: https://www.tabsoverspaces.com/233764-switch-to-errors-instead-of-warnings-for-nullable-reference-types-in-csharp-8-->      
     </WarningsAsErrors>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
   </PropertyGroup>
 
   <ItemGroup>

src/KK.AspNetCore.EasyAuthAuthentication/Services/LocalAuthMeService.cs

@@ -1,3 +1,6 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("KK.AspNetCore.EasyAuthAuthentication.Test")]
 namespace KK.AspNetCore.EasyAuthAuthentication.Services
 {
     using System;
@@ -11,8 +14,7 @@ namespace KK.AspNetCore.EasyAuthAuthentication.Services
     using Microsoft.AspNetCore.Http;
     using Microsoft.Extensions.Logging;
     using Newtonsoft.Json;
-    using Newtonsoft.Json.Linq;
-
+    using Newtonsoft.Json.Linq;    
     internal class LocalAuthMeService
     {
         public LocalAuthMeService(

test/KK.AspNetCore.EasyAuthAuthentication.Test/KK.AspNetCore.EasyAuthAuthentication.Test.csproj

@@ -1,8 +1,6 @@
-<Project Sdk="Microsoft.NET.Sdk">
-
+<Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <TargetFramework>netcoreapp3.1</TargetFramework>
-
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 

test/KK.AspNetCore.EasyAuthAuthentication.Test/Models/LocalProviderOptionTest.cs

@@ -0,0 +1,89 @@
+namespace KK.AspNetCore.EasyAuthAuthentication.Test.Models
+{
+    using System;
+    using System.Collections.Generic;
+    using System.Text;
+    using KK.AspNetCore.EasyAuthAuthentication.Models;
+    using KK.AspNetCore.EasyAuthAuthentication.Services;
+    using Xunit;
+
+    public class LocalProviderOptionTest
+    {
+        [Fact]
+        public void TestIfTheEmptyCtorCreatesEmptyStrings() // not null!
+        {
+            // Arrange
+            // Act
+            var options = new LocalProviderOption();
+            // Assert
+            Assert.Equal(string.Empty, options.AuthEndpoint);
+            Assert.Equal(string.Empty, options.NameClaimType);
+            Assert.Equal(string.Empty, options.RoleClaimType);
+        }
+
+        [Fact]
+        public void ChangeNameClaimTypeIfItsNotAnEmptyString()
+        {
+            // Arrange
+            var options = new LocalProviderOption();
+            // Act
+            options.ChangeModel(new LocalProviderOption()
+            {
+                NameClaimType = "not empty"
+            });
+            // assert
+            Assert.Equal("not empty", options.NameClaimType);
+        }
+        [Fact]
+        public void ChangeAuthEndpointIfItsNotAnEmptyString()
+        {
+            // Arrange
+            var options = new LocalProviderOption();
+            // Act
+            options.ChangeModel(new LocalProviderOption()
+            {
+                AuthEndpoint = "not empty"
+            });
+            // assert
+            Assert.Equal("not empty", options.AuthEndpoint);
+        }
+        [Fact]
+        public void ChangeRoleClaimTypeIfItsNotAnEmptyString()
+        {
+            // Arrange
+            var options = new LocalProviderOption();
+            // Act
+            options.ChangeModel(new LocalProviderOption()
+            {
+                RoleClaimType = "not empty"
+            });
+            // assert
+            Assert.Equal("not empty", options.RoleClaimType);
+        }
+        [Fact]
+        public void NothingChangegIfThereOnlyEmptyStrings()
+        {
+            // Arrange
+            var options = new LocalProviderOption("endpoint", "claim", "role");
+            // Act
+            options.ChangeModel(new LocalProviderOption());
+            // assert
+            Assert.Equal("endpoint", options.AuthEndpoint);
+            Assert.Equal("claim", options.NameClaimType);
+            Assert.Equal("role", options.RoleClaimType);
+        }
+
+        [Fact]
+        public void GetProviderOptionsForLocalAuthMeService()
+        {
+            // Arrange
+            var options = new LocalProviderOption("endpoint", "claim", "role");
+            // Act;
+            var providerOptions = options.GetProviderOptions();
+            // Assert
+            Assert.Equal(typeof(LocalAuthMeService).Name, providerOptions.ProviderName);            
+            Assert.Equal("claim", providerOptions.NameClaimType);
+            Assert.Equal("role", providerOptions.RoleClaimType);
+        }
+    }
+}

test/KK.AspNetCore.EasyAuthAuthentication.Test/Models/ProviederOptionsTest.cs

@@ -81,5 +81,16 @@ public void IfTheOptionsAreSetTheyShouldChanged()
             Assert.Equal("Pferd", options.RoleClaimType);
             Assert.Equal(providerName, options.ProviderName);
         }
+
+        [Fact]
+        public void IfTheClaimTypeIsSetInCtorItMustBePresentInTheOptions()
+        {
+            // Arrange
+            // Act
+            var options = new ProviderOptions("this is a test provieder", "this is a test name claim type");
+            // Assert
+            Assert.Equal("this is a test provieder", options.ProviderName);
+            Assert.Equal("this is a test name claim type", options.NameClaimType);
+        }
     }
 }