Fixed create for stateful parameters. Before the fix, stateful parameters were not added to desired during creates

Author: kevinwang5658

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codify-plugin-lib",
-  "version": "1.0.59",
+  "version": "1.0.60",
   "description": "",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

src/entities/resource-parameters.test.ts

@@ -28,6 +28,48 @@ class TestParameter extends StatefulParameter<TestConfig, string> {
 }
 
 describe('Resource parameter tests', () => {
+  it ('Generates a resource plan that includes stateful parameters (create)', async () => {
+    const statefulParameter = spy(new class extends TestParameter {
+      async refresh(): Promise<string | null> {
+        return null;
+      }
+    })
+
+    const resource = new class extends TestResource {
+      constructor() {
+        super({
+          type: 'resource',
+          parameterOptions: {
+            propA: { statefulParameter }
+          },
+        });
+      }
+
+      async refresh(): Promise<any> {
+        return null;
+      }
+    }
+
+    const plan = await resource.plan({
+      type: 'resource',
+      propA: 'a',
+      propB: 10
+    })
+
+    expect(statefulParameter.refresh.notCalled).to.be.true;
+    expect(plan.currentConfig).toMatchObject({
+      type: 'resource',
+      propA: null,
+      propB: null,
+    })
+    expect(plan.desiredConfig).toMatchObject({
+      type: 'resource',
+      propA: 'a',
+      propB: 10
+    })
+    expect(plan.changeSet.operation).to.eq(ResourceOperation.CREATE);
+  })
+
   it('supports the creation of stateful parameters', async () => {
 
     const statefulParameter = new class extends TestParameter {
@@ -39,7 +81,6 @@ describe('Resource parameter tests', () => {
     const statefulParameterSpy = spy(statefulParameter);
 
     const resource = new class extends TestResource {
-
       constructor() {
         super({
           type: 'resource',

src/entities/resource.ts

@@ -83,6 +83,8 @@ export abstract class Resource<T extends StringIndexedObject> {
       parameterOptions: this.parameterOptions,
     }
 
+    this.addDefaultValues(desiredConfig);
+
     // Parse data from the user supplied config
     const parsedConfig = new ConfigParser(desiredConfig, this.statefulParameters, this.transformParameters)
     const {
@@ -93,15 +95,19 @@ export abstract class Resource<T extends StringIndexedObject> {
       transformParameters,
     } = parsedConfig;
 
-    this.addDefaultValues(resourceParameters);
     await this.applyTransformParameters(transformParameters, resourceParameters);
 
     // Refresh resource parameters. This refreshes the parameters that configure the resource itself
     const currentParameters = await this.refreshResourceParameters(resourceParameters);
 
     // Short circuit here. If the resource is non-existent, there's no point checking stateful parameters
     if (currentParameters == null) {
-      return Plan.create(resourceParameters, null, resourceMetadata, planOptions);
+      return Plan.create(
+        { ...resourceParameters, ...statefulParameters },
+        null,
+        resourceMetadata,
+        planOptions,
+      );
     }
 
     // Refresh stateful parameters. These parameters have state external to the resource

src/index.ts

@@ -3,6 +3,7 @@ import { MessageHandler } from './messages/handlers.js';
 
 export * from './entities/resource.js'
 export * from './entities/resource-types.js'
+export * from './entities/resource-options.js'
 export * from './entities/plugin.js'
 export * from './entities/change-set.js'
 export * from './entities/plan.js'