[CODE-100] Add unique names for duplicate resources

Author: kevinwang5658

src/entities/project.test.ts

@@ -0,0 +1,31 @@
+import { describe, it, expect } from 'vitest';
+import { Project } from './project.js';
+import { Parser } from '../parser/index.js';
+import { File } from '../parser/reader/entities/file.js'
+import { ResourceConfig } from './resource-config.js';
+
+describe('Project Unit Tests', () => {
+  it('Can add unique names for duplicate resources', async () => {
+    const parser = Parser.supportedParsers['json']
+
+    const resourceConfigs = await parser.parse(new File({
+      fileName: 'test',
+      fileType: 'json',
+      contents: JSON.stringify([
+        { type: 'git-clone', remote: 'git@git1' },
+        { type: 'git-clone', remote: 'git@git1' },
+        { type: 'git-clone', remote: 'git@git2' },
+        { type: 'other' }
+      ])
+    }))
+
+    const project = new Project(null, resourceConfigs as ResourceConfig[])
+    project.addUniqueNamesForDuplicateResources()
+
+    expect(project.resourceConfigs[0].id).to.eq('git-clone.0')
+    expect(project.resourceConfigs[1].id).to.eq('git-clone.1')
+    expect(project.resourceConfigs[2].id).to.eq('git-clone.2')
+    expect(project.resourceConfigs[3].id).to.eq('other')
+  })
+
+})

src/entities/project.ts

@@ -3,6 +3,7 @@ import { ValidateResponseData } from 'codify-schemas';
 import { ctx } from '../events/context.js';
 import { DependencyMap } from '../plugins/plugin-manager.js';
 import { DependencyGraphResolver } from '../utils/dependency-graph-resolver.js';
+import { groupBy } from '../utils/index.js';
 import { ProjectConfig } from './project-config.js';
 import { ResourceConfig } from './resource-config.js';
 
@@ -20,6 +21,21 @@ export class Project {
     return this.resourceConfigs.length === 0;
   }
 
+  addUniqueNamesForDuplicateResources() {
+    const groups = groupBy(this.resourceConfigs, (i) => i.id)
+    const duplicates = Object.entries(groups).filter(([, arr]) => arr.length > 1);
+
+    for (const [id, resourceConfigs] of duplicates) {
+      if (resourceConfigs.some((r) => r.name)) {
+        throw new Error(`Duplicate name found for resource: ${id}`);
+      }
+
+      for (const [idx, r] of resourceConfigs.entries()) {
+        r.name = String(idx)
+      }
+    }
+  }
+
   addXCodeToolsConfig() {
     this.resourceConfigs.unshift(new ResourceConfig({
       type: 'xcode-tools'

src/parser/index.ts

@@ -1,8 +1,8 @@
+import { InternalError } from '../common/errors.js';
 import { ConfigBlock } from '../entities/config.js';
 import { Project } from '../entities/project.js';
 import { ProjectConfig } from '../entities/project-config.js';
 import { ResourceConfig } from '../entities/resource-config.js';
-import { InternalError } from '../common/errors.js';
 import { ConfigClass } from './language-definition.js';
 import { FileParser } from './parser/index.js';
 import { JsonFileParser } from './parser/json/file-parser.js';
@@ -26,10 +26,13 @@ export class Parser {
     const configBlocks = await parser.parse(configFile);
     const projectConfig = Parser.findProjectConfig(configBlocks);
 
-    return new Project(
+    const project = new Project(
       projectConfig,
       configBlocks.filter((u) => u.configClass !== ConfigClass.PROJECT) as ResourceConfig[],
     )
+    project.addUniqueNamesForDuplicateResources()
+
+    return project;
   }
 
   private static findProjectConfig(configBlocks: ConfigBlock[]): ProjectConfig | null {