Fixed errors and bugs

Author: kevinwang5658

README.md

@@ -48,14 +48,12 @@ describe the command here
 
 ```
 USAGE
-  $ codify apply [FILE] [-f] [-n <value>] [-p <value>]
+  $ codify apply [FILE] [-p <value>]
 
 ARGUMENTS
   FILE  file to read
 
 FLAGS
-  -f, --force
-  -n, --name=<value>  name to print
   -p, --path=<value>  path to project
 
 DESCRIPTION

package.json

@@ -15,7 +15,8 @@
     "ink": "^4.4.1",
     "@inkjs/ui": "^1.0.0",
     "react": "^18.3.1",
-    "chalk": "^5.3.0"
+    "chalk": "^5.3.0",
+    "parse-json": "^8.1.0"
   },
   "description": "Codify is a set up as code tool for developers",
   "devDependencies": {

src/commands/apply/index.ts

@@ -40,19 +40,19 @@ export default class Apply extends Command {
       if (planResult.plan.every((p) => p.operation === ResourceOperation.NOOP)) {
         console.log('No changes necessary. Exiting');
         await planResult.pluginCollection.destroy();
-        return this.exit(0);
+        return process.exit(0);
       }
 
       const confirm = await reporter.promptApplyConfirmation()
       if (!confirm) {
-        return this.exit(0);
+        return process.exit(0);
       }
 
       await ApplyOrchestrator.run(planResult);
     } catch (error: unknown) {
       console.error(error);
     }
 
-    this.exit(0);
+    process.exit(0);
   }
 }

src/commands/plan/index.ts

@@ -42,6 +42,6 @@ export default class Plan extends Command {
       console.error(error);
     }
 
-    this.exit(0);
+    process.exit(0);
   }
 }

src/parser/parser/json/file-parser.ts

@@ -1,3 +1,5 @@
+import parseJson from 'parse-json';
+
 import { ConfigBlock } from '../../../entities/index.js';
 import { InternalError, JsonFileParseError, SyntaxError } from '../../../utils/errors.js';
 import { File } from '../../reader/entities/file.js';
@@ -17,7 +19,7 @@ export class JsonFileParser implements FileParser {
 
   private parseJson(file: File): unknown {
     try {
-      return JSON.parse(file.contents);
+      return parseJson(file.contents);
     } catch (error) {
       throw new JsonFileParseError({
         fileName: file.fileName,

src/plugins/plugin-process.ts

@@ -19,14 +19,23 @@ export class PluginProcess {
     this.process = process;
   }
 
-  static async start(jsFileDir: string): Promise<PluginProcess> {
+  static async start(pluginPath: string, name: string): Promise<PluginProcess> {
+    const isTypescript = pluginPath.endsWith('.ts');
+    const isTsxInstalled = PluginProcess.isTsxInstalled();
+
+    if (isTypescript && !isTsxInstalled) {
+      throw new Error('Typescript plugins are only allowed for dev mode. TS plugins are not allowed for production');
+    }
+
+    ctx.log(`Starting plugin ${name}`);
+
     const _process = fork(
-      jsFileDir,
+      pluginPath,
       [],
       {
         env: { ...process.env, FORCE_COLOR: '1' },
-        execArgv: ['--import', 'tsx'],
-        silent: true
+        silent: true,
+        ...(isTypescript && { execArgv: ['--import', 'tsx'] }),
       },
     );
 
@@ -53,6 +62,17 @@ export class PluginProcess {
   sendMessage(message: PluginMessage): void {
     this.process.send(message);
   }
+
+  // Tsx is only installed for dev builds. Only allow typescript plugins for testing.
+  private static isTsxInstalled(): boolean {
+    try {
+      require.resolve('tsx');
+    } catch (e) {
+      return false;
+    }
+
+    return true;
+  }
 }
 
 class SendMessageForResultHandler {

src/plugins/plugin.ts

@@ -31,7 +31,7 @@ export class Plugin {
   }
 
   async initialize(): Promise<InitializeResponseData> {
-    this.process = await PluginProcess.start(this.path);
+    this.process = await PluginProcess.start(this.path, this.name);
 
     const initializeResponse = await this.process.sendMessageForResult({ cmd: 'initialize', data: {} });
 

src/plugins/resolver.ts

@@ -4,6 +4,7 @@ import path from 'node:path';
 import { Readable } from 'node:stream';
 import { finished } from 'node:stream/promises';
 
+import { ctx } from '../events/context.js';
 import { Plugin } from './plugin.js';
 
 const DEFAULT_PLUGIN_URL = 'https://codify-plugin-library.s3.amazonaws.com/codify-core/index.js';
@@ -65,6 +66,7 @@ export class PluginResolver {
     try {
       pluginDirStat = await fs.stat(PLUGIN_CACHE_DIR)
     } catch {
+      ctx.log('Plugin cache dir does not exist')
     }
 
     if (pluginDirStat && pluginDirStat.isDirectory()) {
@@ -75,6 +77,7 @@ export class PluginResolver {
       throw new Error(`An object already exists at ${PLUGIN_CACHE_DIR} and is not a directory. Please delete and try again`);
     }
 
+    ctx.log('Creating a new cache dir for codify');
     await fs.mkdir(PLUGIN_CACHE_DIR, { recursive: true });
   }
 }

src/ui/components/plan/plan.tsx

@@ -9,7 +9,6 @@ export function PlanComponent(props: {
   plan: PlanResponseData[]
 }) {
   const filteredPlan = props.plan.filter((p) => p.operation !== ResourceOperation.NOOP);
-  // console.log(JSON.stringify(props.plan, null, 2));
 
   return <Box flexDirection="column">
     <Box borderStyle="round" borderColor="green">