feat: Added codesigning for the new binaries from node-pty. Bumped library versions

Author: kevinwang5658

README.md

@@ -18,7 +18,7 @@ $ npm install -g codify
 $ codify COMMAND
 running command...
 $ codify (--version)
-codify/0.4.0 darwin-arm64 node-v20.15.0
+codify/0.5.0 darwin-arm64 node-v20.15.1
 $ codify --help [COMMAND]
 USAGE
   $ codify COMMAND
@@ -62,7 +62,7 @@ EXAMPLES
   $ codify apply --path ~
 ```
 
-_See code: [src/commands/apply/index.ts](https://github.com/kevinwang5658/codify/blob/v0.4.0/src/commands/apply/index.ts)_
+_See code: [src/commands/apply/index.ts](https://github.com/kevinwang5658/codify/blob/v0.5.0/src/commands/apply/index.ts)_
 
 ## `codify destroy`
 
@@ -88,7 +88,7 @@ EXAMPLES
   $ codify destroy homebrew nvm
 ```
 
-_See code: [src/commands/destroy.ts](https://github.com/kevinwang5658/codify/blob/v0.4.0/src/commands/destroy.ts)_
+_See code: [src/commands/destroy.ts](https://github.com/kevinwang5658/codify/blob/v0.5.0/src/commands/destroy.ts)_
 
 ## `codify help [COMMAND]`
 
@@ -135,7 +135,7 @@ EXAMPLES
   $ codify import homebrew nvm
 ```
 
-_See code: [src/commands/import.ts](https://github.com/kevinwang5658/codify/blob/v0.4.0/src/commands/import.ts)_
+_See code: [src/commands/import.ts](https://github.com/kevinwang5658/codify/blob/v0.5.0/src/commands/import.ts)_
 
 ## `codify plan`
 
@@ -163,7 +163,7 @@ EXAMPLES
   $ codify plan
 ```
 
-_See code: [src/commands/plan/index.ts](https://github.com/kevinwang5658/codify/blob/v0.4.0/src/commands/plan/index.ts)_
+_See code: [src/commands/plan/index.ts](https://github.com/kevinwang5658/codify/blob/v0.5.0/src/commands/plan/index.ts)_
 
 ## `codify update [CHANNEL]`
 

package.json

@@ -12,7 +12,7 @@
     "ajv": "^8.12.0",
     "ajv-formats": "^3.0.1",
     "chalk": "^5.3.0",
-    "codify-schemas": "^1.0.56",
+    "codify-schemas": "^1.0.60",
     "debug": "^4.3.4",
     "ink": "^5",
     "ink-form": "^2.0.1",
@@ -38,7 +38,7 @@
     "@types/semver": "^7.5.4",
     "@types/strip-ansi": "^5.2.1",
     "@typescript-eslint/eslint-plugin": "^8.16.0",
-    "codify-plugin-lib": "^1.0.107",
+    "codify-plugin-lib": "^1.0.129",
     "esbuild": "^0.24.0",
     "esbuild-plugin-copy": "^2.1.1",
     "eslint": "^8.51.0",
@@ -85,7 +85,8 @@
     "topics": {},
     "macos": {
       "identifier": "com.codify.cli",
-      "sign": "\"Developer ID Installer: Qingran Wang (PCG246DPVT)\""
+      "sign": "\"Developer ID Installer: Qingran Wang (PCG246DPVT)\"",
+      "application-certificate": "Developer ID Application: Qingran Wang (PCG246DPVT)"
     },
     "update": {
       "s3": {
@@ -100,6 +101,7 @@
     "build:release": "npm run pkg && ./scripts/notarize.sh",
     "lint": "tsc && eslint . --ext .ts",
     "postpack": "shx rm -f oclif.manifest.json",
+    "pretarball": "../../../scripts/codesign.sh",
     "pkg": "tsx ./scripts/pkg.ts",
     "notorize": "./scripts/notarize.sh",
     "upload": "./scripts/upload.sh",
@@ -110,7 +112,7 @@
     "start:dev": "./bin/dev.js",
     "start:vm": "npm run build && npm run pack:macos && npm run start:vm"
   },
-  "version": "0.4.0",
+  "version": "0.5.0",
   "bugs": "https://github.com/kevinwang5658/codify/issues",
   "keywords": [
     "oclif"

scripts/codesign.sh

@@ -0,0 +1,6 @@
+#!/bin/bash
+
+APPLE_DEVELOPER_APPLICATION_PROFILE=$(cat package.json | jq -r '.oclif.macos."application-certificate"')
+
+codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" node_modules/@homebridge/node-pty-prebuilt-multiarch/build/Release/spawn-helper --force
+codesign --verbose=4 --timestamp --strict --options runtime -s "$APPLE_DEVELOPER_APPLICATION_PROFILE" node_modules/@homebridge/node-pty-prebuilt-multiarch/build/Release/pty.node --force

scripts/pkg.ts

@@ -27,7 +27,6 @@ execSync('tsx esbuild.ts', { shell: 'zsh' })
 console.log(chalk.magenta('Install production dependencies'))
 execSync('npm install --production', { cwd: './.build', shell: 'zsh' })
 
-
 console.log(chalk.magenta('Running oclif pkg macos'))
 execSync('oclif pack macos -r .', { cwd: './.build', shell: 'zsh' })
 

src/entities/plan.ts

@@ -39,6 +39,7 @@ export class ResourcePlan {
   operation: ResourceOperation;
   resourceName?: string;
   resourceType: string;
+  isStateful: boolean;
   parameters: Array<{
     name: string;
     newValue: null | unknown;
@@ -49,6 +50,7 @@ export class ResourcePlan {
   constructor(json: PlanResponseData) {
     this.raw = json;
     this.planId = json.planId;
+    this.isStateful = json.isStateful
     this.operation = json.operation;
     this.resourceName = json.resourceName;
     this.resourceType = json.resourceType;

src/plugins/plugin-manager.ts

@@ -118,7 +118,6 @@ export class PluginManager {
       }
 
       await this.plugins.get(pluginName)!.apply(resourcePlan);
-      await this.validateApply(pluginName, planRequest);
 
       ctx.subprocessFinished(SubProcessName.APPLYING_RESOURCE, resourcePlan.id);
     }
@@ -170,16 +169,4 @@ export class PluginManager {
 
     return resourceMap;
   }
-
-  private async validateApply(pluginName: string, planInput: PlanRequest): Promise<void> {
-    const validationPlan = await this.plugins.get(pluginName)!.plan(planInput);
-    if (validationPlan.operation !== ResourceOperation.NOOP) {
-      throw new Error(`Plugin: '${pluginName}'. Resource: '${planInput.type}'. Additional changes are needed to match the desired plan.
-        
-Validation returned: "${validationPlan.operation}" instead of "${ResourceOperation.NOOP}". These changes are remaining.
-${prettyFormatResourcePlan(validationPlan)}
-      `)
-    }
-  }
-
 }

test/orchestrator/mocks/plugin.ts

@@ -10,8 +10,7 @@ export class MockPlugin {
   name = 'default';
   version = '0.0.0'
   path = '/'
-
-  plugin: Plugin;
+  plugin!: Plugin;
 
   async initialize(secureMode: boolean): Promise<InitializeResponseData> {
     this.plugin = Plugin.create(