feat: improve aws cleanup

Author: kevinwang5658

.github/workflows/run-all-unit-tests.yaml

@@ -32,7 +32,7 @@ jobs:
       - run: npm ci
       - run: npx tsx scripts/cleanup-github-actions.ts
 
-      - name: Setup tmate session
-        uses: mxschmitt/action-tmate@v3
+#      - name: Setup tmate session
+#        uses: mxschmitt/action-tmate@v3
 
-      - run: npm run test -- ./test --no-file-parallelism --disable-console-intercept
+      - run: npm run test -- ./test/aws-cli --no-file-parallelism --silent=passed-only

scripts/cleanup-github-actions.ts

@@ -14,4 +14,5 @@ await testSpawn('rustup self uninstall -y');
 
 await testSpawn('rm -rf /usr/bin/go', { requiresRoot: true })
 await testSpawn('rm -rf /usr/bin/python', { requiresRoot: true })
+await testSpawn('rm -rf /usr/bin/python3', { requiresRoot: true })
 await testSpawn('rm -rf /usr/bin/ruby', { requiresRoot: true })

src/resources/aws-cli/cli/aws-cli.ts

@@ -109,9 +109,17 @@ softwareupdate --install-rosetta
       return;
     }
 
-    await $.spawnSafe(`rm ${installLocation}`, { requiresRoot: true });
-    await $.spawnSafe(`rm ${installLocation}_completer`, { requiresRoot: true });
-    await $.spawnSafe('rm -rf $HOME/.aws/');
+    if (Utils.isLinux()) {
+      // Remove symlinks from bin dir
+      await $.spawnSafe('rm -f /usr/local/bin/aws', { requiresRoot: true });
+      await $.spawnSafe('rm -f /usr/local/bin/aws_completer', { requiresRoot: true });
+
+      // Remove the install directory (always /usr/local/aws-cli for the standalone installer)
+      await $.spawnSafe('rm -rf /usr/local/aws-cli', { requiresRoot: true });
+    } else {
+      await $.spawnSafe(`rm ${installLocation}`, { requiresRoot: true });
+      await $.spawnSafe(`rm ${installLocation}_completer`, { requiresRoot: true });
+    }
   }
 
   private async findInstallLocation(): Promise<null | string> {