fix(api-request-builder): Change orderNumber to string (#1599)

Author: rmhartog

packages/api-request-builder/src/query-id.js

@@ -73,12 +73,12 @@ export function byCustomerId(custId: string): Object {
  * Set the given `orderNumber` to the `orderNumber` internal state of the service instance.
  * For querying orders
  *
- * @param  {number} orderNumber - An order number
+ * @param  {string} orderNumber - An order number
  * @throws If `orderNumber` is missing or invalid
  * @return {Object} The instance of the service, can be chained.
  */
-export function byOrderNumber(orderNumber: number): Object {
-  if (typeof orderNumber !== 'number')
+export function byOrderNumber(orderNumber: string): Object {
+  if (typeof orderNumber !== 'string')
     throw new Error(
       'Required argument for `byOrderNumber` is missing or invalid'
     )

packages/api-request-builder/test/create-service.spec.js

@@ -425,7 +425,7 @@ describe('createService', () => {
       })
 
       test('should mix orderNumber and queryParams', () => {
-        expect(service.byOrderNumber(123).expand('baz').build()).toBe(
+        expect(service.byOrderNumber('123').expand('baz').build()).toBe(
           '/my-project1/test/order-number=123?expand=baz'
         )
       })

packages/api-request-builder/test/query-id.spec.js

@@ -41,8 +41,8 @@ describe('queryId', () => {
   })
 
   test('should set the orderNumber param', () => {
-    service.byOrderNumber(123)
-    expect(service.params.orderNumber).toBe(123)
+    service.byOrderNumber('123')
+    expect(service.params.orderNumber).toBe('123')
   })
 
   test('should throw if orderNumber is missing', () => {
@@ -52,7 +52,7 @@ describe('queryId', () => {
   })
 
   test('should throw if orderNumber is invalid', () => {
-    expect(() => service.byOrderNumber('hi')).toThrow(
+    expect(() => service.byOrderNumber(123)).toThrow(
       /Required argument for `byOrderNumber` is missing/
     )
   })