Skip to content

Commit ba6d674

Browse files
committed
fix: remove unused onPreviewReady() in page and modalOrchestrator components
1 parent 250f845 commit ba6d674

5 files changed

Lines changed: 5 additions & 85 deletions

File tree

apps/google-docs/src/locations/Page/Page.tsx

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ const Page = () => {
1717
const [oauthToken, setOauthToken] = useState<string>('');
1818
const [isOAuthConnected, setIsOAuthConnected] = useState(false);
1919
const [isOAuthLoading, setIsOAuthLoading] = useState(true);
20-
const [previewPayload, setPreviewPayload] = useState<PreviewPayload | null>(null);
2120
const [mappingReviewPayload, setMappingReviewPayload] =
2221
useState<MappingReviewSuspendPayload | null>(null);
2322
const [fixtureReviewPayload, setFixtureReviewPayload] =
@@ -59,27 +58,20 @@ const Page = () => {
5958
modalOrchestratorRef.current?.startFlow();
6059
};
6160

62-
const handlePreviewReady = (payload: PreviewPayload) => {
63-
setPreviewPayload(payload);
64-
};
65-
6661
const handleMappingReviewReady = (payload: MappingReviewSuspendPayload) => {
6762
setMappingReviewPayload(payload);
6863
};
6964

7065
const handleReturnToMainPage = () => {
71-
setPreviewPayload(null);
7266
setMappingReviewPayload(null);
7367
};
7468

75-
const activePreviewPayload = mappingReviewPayload;
76-
7769
return (
7870
<>
7971
<Layout withBoxShadow={true} offsetTop={10}>
80-
{activePreviewPayload ? (
72+
{mappingReviewPayload ? (
8173
<MappingReviewPage
82-
payload={activePreviewPayload}
74+
payload={mappingReviewPayload}
8375
onLeaveReview={handleReturnToMainPage}
8476
/>
8577
) : (
@@ -107,7 +99,6 @@ const Page = () => {
10799
ref={modalOrchestratorRef}
108100
sdk={sdk}
109101
oauthToken={oauthToken}
110-
onPreviewReady={handlePreviewReady}
111102
onMappingReviewReady={handleMappingReviewReady}
112103
onResetToMain={handleReturnToMainPage}
113104
/>

apps/google-docs/src/locations/Page/components/mainpage/MappingReviewPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { useState } from 'react';
2-
import { Button, Flex, Heading, Layout, Paragraph } from '@contentful/f36-components';
2+
import { Button, Flex, Heading, Layout } from '@contentful/f36-components';
33
import type { MappingReviewSuspendPayload } from '@types';
44
import Splitter from './Splitter';
55
import { ConfirmCancelModal } from '../modals/ConfirmCancelModal';

apps/google-docs/src/locations/Page/components/mainpage/ModalOrchestrator.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,12 @@ enum FlowStep {
3636
interface ModalOrchestratorProps {
3737
sdk: PageAppSDK;
3838
oauthToken: string;
39-
onPreviewReady: (payload: PreviewPayload) => void;
4039
onMappingReviewReady: (payload: MappingReviewSuspendPayload) => void;
4140
onResetToMain: () => void;
4241
}
4342

4443
export const ModalOrchestrator = forwardRef<ModalOrchestratorHandle, ModalOrchestratorProps>(
45-
({ sdk, oauthToken, onPreviewReady, onMappingReviewReady, onResetToMain }, ref) => {
44+
({ sdk, oauthToken, onMappingReviewReady, onResetToMain }, ref) => {
4645
const [isUploadModalOpen, setIsUploadModalOpen] = useState(false);
4746
const [isConfirmCancelModalOpen, setIsConfirmCancelModalOpen] = useState(false);
4847
const [isErrorPreviewModalOpen, setIsErrorPreviewModalOpen] = useState(false);
@@ -152,7 +151,6 @@ export const ModalOrchestrator = forwardRef<ModalOrchestratorHandle, ModalOrches
152151
}
153152

154153
setFlowStep(null);
155-
onPreviewReady(workflowRun.googleDocPayload);
156154
};
157155

158156
const continueWorkflow = async (resumePayloadOverrides?: Partial<ResumePayload>) => {

apps/google-docs/src/locations/Page/components/review/DocumentOutline.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { useLayoutEffect, useMemo, useRef, useState, type RefCallback } from 'react';
22
import { Box, Card, Flex, Text } from '@contentful/f36-components';
33
import tokens from '@contentful/f36-tokens';
4-
import type { MappingReviewSuspendPayload, NormalizedDocumentFlattenedRun } from '@types';
4+
import type { MappingReviewSuspendPayload } from '@types';
55
import { FileTextIcon } from '@contentful/f36-icons';
66
import { MappingCard, type MappingCardData } from './MappingCard';
77
import { getAnchorIdForSourceRef, resolveMarkerOffsets } from './utils/mappingCardPositioning';

apps/google-docs/test/locations/Page/components/mainpage/PreviewPageView.spec.tsx

Lines changed: 0 additions & 69 deletions
This file was deleted.

0 commit comments

Comments
 (0)