Refactor test file paths to use relative paths for config.json and improve error handling in auth-handler tests

Author: harshitha-cstk

packages/contentstack-auth/test/unit/auth-handler.test.ts

@@ -6,7 +6,7 @@ import { User } from '../../src/interfaces';
 import { readFileSync } from 'fs';
 import { join } from 'path';
 
-const config = JSON.parse(readFileSync(join(__dirname, '../config.json'), "utf-8"));
+const config = JSON.parse(readFileSync(join(__dirname, './config.json'), 'utf-8'));
 
 const user: User = { email: '***REMOVED***', authtoken: 'testtoken' };
 const credentials = { email: '***REMOVED***', password: config.password };
@@ -32,8 +32,9 @@ describe('Auth Handler', function () {
               return Promise.reject(new Error('Invalid 2FA code'));
             }
           } else {
-            // Handler expects 2FA required as a rejection (catch path checks error.errorCode === 294)
-            return Promise.reject({ errorCode: 294 });
+            const error: any = new Error('2FA required');
+            error.errorCode = 294;
+            return Promise.reject(error);
           }
         }
         return Promise.resolve({ user });
@@ -117,13 +118,23 @@ describe('Auth Handler', function () {
     it('Login with 2FA enabled invalid otp, failed to login', async function () {
       this.timeout(10000);
       TFAEnabled = true;
-      let result;
+      askOTPStub.restore();
+      askOTPStub = sinon.stub(interactive, 'askOTP').callsFake(function () {
+        return Promise.resolve(InvalidTFATestToken);
+      });
       try {
-        result = await authHandler.login(credentials.email, credentials.password);
+        await authHandler.login(credentials.email, credentials.password);
+        expect.fail('Should have thrown an error');
       } catch (error) {
-        result = error;
+        expect(error).to.be.instanceOf(Error);
+        expect((error as Error).message).to.include('Invalid 2FA code');
+      } finally {
+        TFAEnabled = false;
+        askOTPStub.restore();
+        askOTPStub = sinon.stub(interactive, 'askOTP').callsFake(function () {
+          return Promise.resolve(TFATestToken);
+        });
       }
-      TFAEnabled = false;
     });
 
     it('Login with 2FA enabled with sms channel, should be logged in successfully', async function () {
@@ -166,4 +177,4 @@ describe('Auth Handler', function () {
       }
     });
   });
-});
+});

packages/contentstack-auth/test/unit/commands/login.test.ts

@@ -12,7 +12,7 @@ import * as managementSDK from '@contentstack/cli-utilities';
 import { readFileSync } from 'fs';
 import { join } from 'path';
 
-const conf = JSON.parse(readFileSync(join(__dirname, '../../config.json'), "utf-8"));
+const conf = JSON.parse(readFileSync(join(__dirname, '../config.json'), "utf-8"));
 
 const config = configHandler;
 

packages/contentstack-auth/test/unit/commands/logout.test.ts

@@ -12,7 +12,7 @@ import * as managementSDK from '@contentstack/cli-utilities';
 import { readFileSync } from 'fs';
 import { join } from 'path';
 
-const conf = JSON.parse(readFileSync(join(__dirname, '../../config.json'), "utf-8"));
+const conf = JSON.parse(readFileSync(join(__dirname, '../config.json'), "utf-8"));
 
 const config = configHandler;
 

packages/contentstack-auth/test/unit/commands/tokens-add.test.ts

@@ -8,7 +8,7 @@ import nock from 'nock';
 import { readFileSync } from 'fs';
 import { join } from 'path';
 
-const conf = JSON.parse(readFileSync(join(__dirname, '../../config.json'), "utf-8"));
+const conf = JSON.parse(readFileSync(join(__dirname, '../config.json'), "utf-8"));
 
 dotenvConfig();
 

packages/contentstack-auth/test/unit/interactive.test.ts

@@ -5,7 +5,7 @@ import { cliux } from '@contentstack/cli-utilities';
 import { readFileSync } from 'fs';
 import { join } from 'path';
 
-const config = JSON.parse(readFileSync(join(__dirname, '../config.json'), "utf-8"));
+const config = JSON.parse(readFileSync(join(__dirname, './config.json'), "utf-8"));
 
 describe('Interactive', () => {
   let inquireStub: sinon.SinonStub;

packages/contentstack-auth/test/utils/auth-handler.test.ts

@@ -6,7 +6,7 @@ import { User } from '../../src/interfaces';
 import { readFileSync } from 'fs';
 import { join } from 'path';
 
-const config = JSON.parse(readFileSync(join(__dirname, '../config.json'), "utf-8"));
+const config = JSON.parse(readFileSync(join(__dirname, '../unit/config.json'), "utf-8"));
 
 const user: User = { email: '***REMOVED***', authtoken: 'testtoken' };
 const credentials = { email: '***REMOVED***', password: config.password };