Skip to content

Commit fafcff1

Browse files
committed
PYCO-68: Remove HTTPTransport from blocking API
1 parent e4a00c8 commit fafcff1

3 files changed

Lines changed: 2 additions & 252 deletions

File tree

acouchbase_analytics/protocol/_core/client_adapter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def __init__(
4848
self._opts_builder = OptionsBuilder()
4949
kwargs['logger_name'] = self.logger_name
5050
self._conn_details = _ConnectionDetails.create(self._opts_builder, http_endpoint, credential, options, **kwargs)
51-
# TODO: do we want to support custom HTTP transports for the async client?
51+
# PYCO-67: Do we want to allow supporting custom HTTP transports?
5252
self._http_transport_cls = None
5353

5454
@property

couchbase_analytics/protocol/_core/client_adapter.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
from couchbase_analytics.protocol.connection import _ConnectionDetails
2828
from couchbase_analytics.protocol.options import OptionsBuilder
2929

30-
# from couchbase_analytics.protocol.core._http_transport import AnalyticsHTTPTransport
31-
3230
if TYPE_CHECKING:
3331
from couchbase_analytics.protocol._core.request import QueryRequest
3432

@@ -48,9 +46,7 @@ def __init__(
4846
self._prefix = ''
4947
self._cluster_id = cast(str, kwargs.pop('cluster_id', ''))
5048
self._opts_builder = OptionsBuilder()
51-
# TODO: We should limit the allowed transports to the ones we support
52-
# Question is how do we want to limit the transports? Should users even need to override?
53-
# self._http_transport_cls = kwargs.pop('http_transport_cls', AnalyticsHTTPTransport)
49+
# PYCO-67: Do we want to allow supporting custom HTTP transports?
5450
self._http_transport_cls = None
5551
kwargs['logger_name'] = self.logger_name
5652
self._conn_details = _ConnectionDetails.create(self._opts_builder, http_endpoint, credential, options, **kwargs)

couchbase_analytics/protocol/_core/http_transport.py

Lines changed: 0 additions & 246 deletions
This file was deleted.

0 commit comments

Comments
 (0)