update invalidContainer check

ludviggunne · ludviggunne · commit ba0dca66d30a · 2026-05-11T15:38:05.000+02:00
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -1193,8 +1193,7 @@ void CheckStl::invalidContainer()
                         if (info.tok->variable()->isReference() && !isVariableDecl(info.tok) &&
                             reaches(info.tok->variable()->nameToken(), tok, nullptr)) {
 
-                            if ((assignExpr && Token::Match(assignExpr->astOperand1(), "& %varid%", info.tok->varId())) || // TODO: fix AST
-                                Token::Match(assignExpr, "& %varid% {|(", info.tok->varId())) {
+                            if ((assignExpr && Token::Match(assignExpr->astOperand1()->previous(), "& %varid%", info.tok->varId()))) {
                                 return false;
                             }
 

Original file line number	Diff line number	Diff line change
`@@ -1193,8 +1193,7 @@ void CheckStl::invalidContainer()`
`1193`	`1193`	`if (info.tok->variable()->isReference() && !isVariableDecl(info.tok) &&`
`1194`	`1194`	`reaches(info.tok->variable()->nameToken(), tok, nullptr)) {`
`1195`	`1195`
`1196`		`- if ((assignExpr && Token::Match(assignExpr->astOperand1(), "& %varid%", info.tok->varId())) \|\| // TODO: fix AST`
`1197`		`- Token::Match(assignExpr, "& %varid% {\|(", info.tok->varId())) {`
	`1196`	`+ if ((assignExpr && Token::Match(assignExpr->astOperand1()->previous(), "& %varid%", info.tok->varId()))) {`
`1198`	`1197`	`return false;`
`1199`	`1198`	`}`
`1200`	`1199`