fix: improve type handling and update comment handling logic

Author: tanhongit

phpstan-baseline.neon

@@ -12,5 +12,8 @@ parameters:
         - message: '#Cannot cast mixed to int#'
           path: src/*.php
 
+        - message: '#Cannot access an offset on mixed.#'
+          path: src/*.php
+
         - message: '#Cannot access offset .+ on mixed#'
           path: src/*.php

src/Jobs/ProcessAggregatedEvents.php

@@ -57,7 +57,7 @@ public function handle(): void
     /**
      * Aggregate messages from events.
      *
-     * @param  list<string>  $eventMessages
+     * @param  array<string, mixed>  $eventMessages
      *
      * @return string
      */

src/Jobs/ProcessWebhookEvent.php

@@ -16,11 +16,11 @@ class ProcessWebhookEvent implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
-    protected array $eventData;
-
     /**
      * @param  array<string, mixed>  $eventData
      */
+    protected array $eventData;
+
     public function __construct(array $eventData)
     {
         $this->eventData = $eventData;
@@ -35,7 +35,7 @@ public function handle(): void
         $commentAggregationCacheKey = config('github-project.comment_aggregation_cache_key')."_{$nodeId}";
         $commentAggregationTime = (int) config('github-project.comment_aggregation_time');
 
-        $eventMessages = Cache::get($commentAggregationCacheKey, []);
+        $eventMessages = (array) Cache::get($commentAggregationCacheKey, []);
         $eventMessages[] = view('github-project::md.shared.content', ['payload' => $this->eventData])->render();
 
         Cache::put($commentAggregationCacheKey, $eventMessages, now()->addSeconds($commentAggregationTime));

src/Services/GithubService.php

@@ -52,14 +52,15 @@ public function commentOnNode(string $contentNodeId, string $message): array
      */
     public function handleComment(array $payload): void
     {
-        $contentNodeId = (string) $payload['projects_v2_item']['content_node_id'] ?? '';
-
         if (config('github-project.is_queue_enabled')) {
             ProcessWebhookEvent::dispatch($payload);
 
             return;
         }
 
-        $this->commentOnNode($contentNodeId, view('github-project::md.comment', compact('payload'))->render());
+        $this->commentOnNode(
+            (string) $payload['projects_v2_item']['content_node_id'],
+            view('github-project::md.comment', compact('payload'))->render()
+        );
     }
 }