refactor: simplify ProcessAggregatedEvents and ProcessWebhookEvent classes by removing unnecessary logging and GitHub service dependency injection

Author: tanhongit

src/Jobs/ProcessAggregatedEvents.php

@@ -9,7 +9,6 @@
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Cache;
-use Illuminate\Support\Facades\Log;
 
 class ProcessAggregatedEvents implements ShouldQueue
 {
@@ -20,15 +19,12 @@ class ProcessAggregatedEvents implements ShouldQueue
 
     protected string $nodeId;
 
-    protected GithubService $githubService;
-
     /**
      * Create a new job instance.
      */
-    public function __construct(string $nodeId, GithubService $githubService)
+    public function __construct(string $nodeId)
     {
         $this->nodeId = $nodeId;
-        $this->githubService = $githubService;
     }
 
     /**
@@ -41,19 +37,19 @@ public function handle(): void
         /** @var array<string, mixed> $eventMessages */
         $eventMessages = Cache::pull($commentAggregationCacheKey, []);
 
-        Log::info('ProcessAggregatedEvents: Event message: '.json_encode($eventMessages));
         $message = $this->aggregateMessages($eventMessages);
+        $author = Cache::pull($commentAggregationCacheKey.'_author', []);
+
         Cache::forget($commentAggregationCacheKey);
-        $author = Cache::pull($commentAggregationCacheKey.'_author', '');
+        Cache::forget($commentAggregationCacheKey.'_author');
 
-        Log::info('ProcessAggregatedEvents: Author: '.$author);
         $message .= '\n\n'.view(
             'github-project::md.shared.author',
             ['name' => $author['name'], 'html_url' => $author['html_url']]
         )->render();
 
-        Log::info('ProcessAggregatedEvents: Message: '.$message);
-        $this->githubService->commentOnNode($this->nodeId, $message);
+        $githubService = new GithubService();
+        $githubService->commentOnNode($this->nodeId, $message);
     }
 
     /**

src/Jobs/ProcessWebhookEvent.php

@@ -8,7 +8,6 @@
 use Illuminate\Queue\InteractsWithQueue;
 use Illuminate\Queue\SerializesModels;
 use Illuminate\Support\Facades\Cache;
-use Illuminate\Support\Facades\Log;
 
 class ProcessWebhookEvent implements ShouldQueue
 {
@@ -44,7 +43,7 @@ public function handle(): void
         $eventMessages = (array) Cache::get($commentAggregationCacheKey, []);
         $eventMessages[] = view('github-project::md.shared.content', ['payload' => $this->eventData])->render();
 
-        Cache::put($commentAggregationCacheKey, $eventMessages, now()->addSeconds($commentAggregationTime));
+        Cache::put($commentAggregationCacheKey, $eventMessages, now()->addSeconds($commentAggregationTime + 3));
 
         if (!Cache::has($commentAggregationCacheKey.'_author')) {
             Cache::put(
@@ -53,12 +52,10 @@ public function handle(): void
                     'name' => $this->eventData['sender']['login'],
                     'html_url' => $this->eventData['sender']['html_url'],
                 ],
-                now()->addSeconds($commentAggregationTime)
+                now()->addSeconds($commentAggregationTime + 3)
             );
         }
-        Log::info('Event message count: '.count($eventMessages));
-        Log::info('Event message: '.json_encode($eventMessages));
-        Log::info('Event author: '.json_encode(Cache::get($commentAggregationCacheKey.'_author')));
+
         if (count($eventMessages) === 1) {
             ProcessAggregatedEvents::dispatch($nodeId)->delay(now()->addSeconds($commentAggregationTime));
         }