Updated pyright config and silenced warnings (#3203)

Author: AndreasArvidsson

.vscode/settings.json

@@ -28,13 +28,9 @@
     ".busted": "lua"
   },
   "files.eol": "\n",
-  "github.copilot.chat.codeGeneration.instructions": [
-    {
-      "file": "./packages/cursorless-org-docs/src/docs/contributing/scope-test-format.md"
-    }
-  ],
-  "typescript.enablePromptUseWorkspaceTsdk": true,
-  "typescript.tsdk": "node_modules/typescript/lib",
+  "js/ts.tsdk.promptToUseWorkspaceVersion": true,
+  "js/ts.tsdk": "node_modules/typescript/lib",
+  "python.analysis.diagnosticMode": "workspace",
   // Turn off tsc task auto detection since we have the necessary tasks as npm scripts
-  "typescript.tsc.autoDetect": "off"
+  "js/ts.tsc.autoDetect": "off"
 }

AGENTS.md

@@ -36,6 +36,7 @@ When documenting actions or modifiers:
 - Many actions (`drop`, `float`, `puff`) work with both line and non-line targets
 - Always check test fixtures in `/data/fixtures/recorded/` to understand behavior
 - Implementation for many actions is in `/packages/cursorless-engine/src/actions/`
+- After running Python scripts or tests, delete any `__pycache__` directories and `.pyc` files created under the repository root.
 
 ## Scope test format
 

cursorless-everywhere-talon/cursorless_everywhere_talon.py

@@ -24,22 +24,25 @@
 
 @ctx.action_class("user")
 class UserActions:
+    @staticmethod
     def private_cursorless_run_rpc_command_and_wait(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any = None,
         arg2: Any = None,
     ):
         actions.user.private_cursorless_talonjs_run_and_wait(command_id, arg1, arg2)
 
+    @staticmethod
     def private_cursorless_run_rpc_command_no_wait(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any = None,
         arg2: Any = None,
     ):
         actions.user.private_cursorless_talonjs_run_no_wait(command_id, arg1, arg2)
 
+    @staticmethod
     def private_cursorless_run_rpc_command_get(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any = None,
         arg2: Any = None,
     ) -> Any:
@@ -52,33 +55,32 @@ class Actions:
     def cursorless_everywhere_get_editor_state() -> EditorState:  # pyright: ignore [reportReturnType]
         """Get the focused editor element state"""
 
-    def cursorless_everywhere_set_selections(
-        selections: list[SelectionOffsets],  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_set_selections(selections: list[SelectionOffsets]):
         """Set focused element selections"""
 
-    def cursorless_everywhere_edit_text(
-        edit: EditorEdit,  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_edit_text(edit: EditorEdit):
         """Edit focused element text"""
 
-    def cursorless_everywhere_flash_ranges(
-        ranges: list[RangeOffsets],  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_flash_ranges(ranges: list[RangeOffsets]):
         """Flash ranges in focused element"""
         actions.skip()
 
     # Private actions
 
+    @staticmethod
     def private_cursorless_talonjs_run_and_wait(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any = None,
         arg2: Any = None,
     ):
         """Executes a Cursorless command, waits for its completion, but does not return the response"""
 
+    @staticmethod
     def private_cursorless_talonjs_run_no_wait(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any = None,
         arg2: Any = None,
     ):

cursorless-everywhere-talon/cursorless_everywhere_talon_browser.py

@@ -33,9 +33,8 @@ def cursorless_everywhere_get_editor_state() -> EditorState:
             return actions.next()
         return res
 
-    def cursorless_everywhere_set_selections(
-        selections: list[SelectionOffsets],  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_set_selections(selections: list[SelectionOffsets]):
         command = {
             "id": "setSelections",
             "selections": [
@@ -47,9 +46,8 @@ def cursorless_everywhere_set_selections(
         if use_fallback(res):
             actions.next(selections)
 
-    def cursorless_everywhere_edit_text(
-        edit: EditorEdit,  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_edit_text(edit: EditorEdit):
         command = {
             "id": "editText",
             "text": edit["text"],
@@ -62,9 +60,8 @@ def cursorless_everywhere_edit_text(
         if use_fallback(res):
             actions.next(edit)
 
-    def cursorless_everywhere_flash_ranges(
-        ranges: list[RangeOffsets],  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_flash_ranges(ranges: list[RangeOffsets]):
         command = {
             "id": "flashRanges",
             "ranges": [

cursorless-everywhere-talon/cursorless_everywhere_talon_win.py

@@ -1,13 +1,18 @@
-from talon import Context, app, ui
+import sys
+from typing import Any
+
+from talon import Context, ui
 
 from .cursorless_everywhere_talon import (
     EditorEdit,
     EditorState,
     SelectionOffsets,
 )
 
-if app.platform == "windows":
+if sys.platform == "win32":
     from talon.windows.ax import TextRange
+else:
+    TextRange = Any
 
 
 # https://learn.microsoft.com/en-us/dotnet/api/system.windows.automation.text.textpatternrange?view=windowsdesktop-8.0
@@ -47,9 +52,8 @@ def cursorless_everywhere_get_editor_state() -> EditorState:
             "selections": selections,
         }
 
-    def cursorless_everywhere_set_selections(
-        selections: list[SelectionOffsets],  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_set_selections(selections: list[SelectionOffsets]):
         if selections.length != 1:  # pyright: ignore [reportAttributeAccessIssue]
             raise ValueError("Only single selection supported")
 
@@ -67,9 +71,8 @@ def cursorless_everywhere_set_selections(
 
         set_selection(document_range, anchor, active)
 
-    def cursorless_everywhere_edit_text(
-        edit: EditorEdit,  # pyright: ignore [reportGeneralTypeIssues]
-    ):
+    @staticmethod
+    def cursorless_everywhere_edit_text(edit: EditorEdit):
         text = edit["text"]
 
         el = ui.focused_element()

cursorless-talon-dev/src/spoken_form_test.py

@@ -45,22 +45,25 @@ class UserActions:
     def did_emit_pre_phrase_signal():
         return True
 
+    @staticmethod
     def private_cursorless_run_rpc_command_and_wait(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any,
         arg2: Any = None,
     ):
         commands_run.append(arg1)
 
+    @staticmethod
     def private_cursorless_run_rpc_command_no_wait(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any,
         arg2: Any = None,
     ):
         commands_run.append(arg1)
 
+    @staticmethod
     def private_cursorless_run_rpc_command_get(
-        command_id: str,  # pyright: ignore [reportGeneralTypeIssues]
+        command_id: str,
         arg1: Any,
         arg2: Any = None,
     ) -> Any:
@@ -70,7 +73,8 @@ def private_cursorless_run_rpc_command_get(
 
 @mod.action_class
 class Actions:
-    def private_cursorless_spoken_form_test_mode(enable: bool):  # pyright: ignore [reportGeneralTypeIssues]
+    @staticmethod
+    def private_cursorless_spoken_form_test_mode(enable: bool):
         """Enable/disable Cursorless spoken form test mode"""
         global saved_modes, saved_microphone
 
@@ -97,8 +101,9 @@ def private_cursorless_spoken_form_test_mode(enable: bool):  # pyright: ignore [
                 "Cursorless spoken form tests are done. Talon microphone is re-enabled."
             )
 
+    @staticmethod
     def private_cursorless_spoken_form_test(
-        phrase: str,  # pyright: ignore [reportGeneralTypeIssues]
+        phrase: str,
         mockedGetValue_: Optional[str],
     ):
         """Run Cursorless spoken form test"""

cursorless-talon/src/actions/actions.py

@@ -88,7 +88,8 @@ def cursorless_action_or_ide_command(m) -> dict[str, str]:
 
 @mod.action_class
 class Actions:
-    def cursorless_command(action_name: str, target: CursorlessExplicitTarget):  # pyright: ignore [reportGeneralTypeIssues]
+    @staticmethod
+    def cursorless_command(action_name: str, target: CursorlessExplicitTarget):
         """Perform cursorless command on target"""
         if action_name in callback_actions:
             callback_actions[action_name](target)
@@ -109,29 +110,33 @@ def cursorless_command(action_name: str, target: CursorlessExplicitTarget):  # p
             action = {"name": action_name, "target": target}
             actions.user.private_cursorless_command_and_wait(action)
 
-    def cursorless_vscode_command(command_id: str, target: CursorlessTarget):  # pyright: ignore [reportGeneralTypeIssues]
+    @staticmethod
+    def cursorless_vscode_command(command_id: str, target: CursorlessTarget):
         """
         Perform vscode command on cursorless target
 
         Deprecated: prefer `cursorless_ide_command`
         """
         return actions.user.cursorless_ide_command(command_id, target)
 
-    def cursorless_ide_command(command_id: str, target: CursorlessTarget):  # pyright: ignore [reportGeneralTypeIssues]
+    @staticmethod
+    def cursorless_ide_command(command_id: str, target: CursorlessTarget):
         """Perform ide command on cursorless target"""
         return cursorless_execute_command_action(command_id, target)
 
+    @staticmethod
     def cursorless_insert(
-        destination: CursorlessDestination,  # pyright: ignore [reportGeneralTypeIssues]
+        destination: CursorlessDestination,
         text: Union[str, list[str]],
     ):
         """Perform text insertion on Cursorless destination"""
         if isinstance(text, str):
             text = [text]
         cursorless_replace_action(destination, text)
 
+    @staticmethod
     def private_cursorless_action_or_ide_command(
-        instruction: dict[str, str],  # pyright: ignore [reportGeneralTypeIssues]
+        instruction: dict[str, str],
         target: CursorlessTarget,
     ):
         """Perform cursorless action or ide command on target (internal use only)"""

cursorless-talon/src/actions/bring_move.py

@@ -35,7 +35,8 @@ def cursorless_bring_move_targets(m) -> BringMoveTargets:
 
 @mod.action_class
 class Actions:
-    def private_cursorless_bring_move(action_name: str, targets: BringMoveTargets):  # pyright: ignore [reportGeneralTypeIssues]
+    @staticmethod
+    def private_cursorless_bring_move(action_name: str, targets: BringMoveTargets):
         """Execute Cursorless move/bring action"""
         actions.user.private_cursorless_command_and_wait(
             {

cursorless-talon/src/actions/call.py

@@ -8,8 +8,9 @@
 
 @mod.action_class
 class Actions:
+    @staticmethod
     def private_cursorless_call(
-        callee: CursorlessTarget,  # pyright: ignore [reportGeneralTypeIssues]
+        callee: CursorlessTarget,
         argument: CursorlessTarget = ImplicitTarget(),
     ):
         """Execute Cursorless call action"""

cursorless-talon/src/actions/generate_snippet.py

@@ -10,7 +10,8 @@
 
 @mod.action_class
 class Actions:
-    def private_cursorless_generate_snippet_action(target: CursorlessExplicitTarget):  # pyright: ignore [reportGeneralTypeIssues]
+    @staticmethod
+    def private_cursorless_generate_snippet_action(target: CursorlessExplicitTarget):
         """Generate a snippet from the given target"""
         actions.user.private_cursorless_command_no_wait(
             {