Sort imports on formatting (#3254)

Author: AndreasArvidsson

.oxfmtrc.json

@@ -1,6 +1,12 @@
 {
   "$schema": "./node_modules/oxfmt/configuration_schema.json",
   "sortPackageJson": false,
+  "sortImports": {
+    "newlinesBetween": false,
+    "partitionByNewline": true,
+    "internalPattern": ["@cursorless/"]
+  },
+
   "ignorePatterns": [
     "/packages/app-vscode/src/keyboard/grammar/generated/",
     "/packages/lib-engine/src/customCommandGrammar/generated/",

packages/app-neovim/src/NeovimCommandServerApi.ts

@@ -1,9 +1,9 @@
+import type { NeovimClient } from "neovim/lib/api/client";
 import type {
   CommandServerApi,
   FocusedElementType,
   InboundSignal,
 } from "@cursorless/lib-common";
-import type { NeovimClient } from "neovim/lib/api/client";
 
 export class NeovimCommandServerApi implements CommandServerApi {
   signals: { prePhrase: InboundSignal };

packages/app-neovim/src/extension.ts

@@ -1,3 +1,5 @@
+import type { NeovimClient } from "neovim/lib/api/client";
+import type { NvimPlugin } from "neovim/lib/host/NvimPlugin";
 import {
   FakeCommandServerApi,
   FakeIDE,
@@ -6,10 +8,8 @@ import {
 import { createCursorlessEngine } from "@cursorless/lib-engine";
 import { EXTENSION_ID, NeovimIDE } from "@cursorless/lib-neovim-common";
 import { getNeovimRegistry } from "@cursorless/lib-neovim-registry";
-import type { NeovimClient } from "neovim/lib/api/client";
-import type { NvimPlugin } from "neovim/lib/host/NvimPlugin";
-import { NeovimCommandServerApi } from "./NeovimCommandServerApi";
 import { constructTestHelpers } from "./constructTestHelpers";
+import { NeovimCommandServerApi } from "./NeovimCommandServerApi";
 import { registerCommands } from "./registerCommands";
 
 /**

packages/app-neovim/src/registerCommands.ts

@@ -1,3 +1,4 @@
+import type { NeovimClient } from "neovim";
 import type {
   CommandResponse,
   CommandServerApi,
@@ -8,15 +9,13 @@ import {
   clientSupportsFallback,
   ensureCommandShape,
 } from "@cursorless/lib-common";
-
 import type { CommandApi } from "@cursorless/lib-engine";
 import type { NeovimIDE } from "@cursorless/lib-neovim-common";
 import {
   modeSwitchNormalTerminal,
   modeSwitchTerminal,
 } from "@cursorless/lib-neovim-common";
 import { getNeovimRegistry } from "@cursorless/lib-neovim-registry";
-import type { NeovimClient } from "neovim";
 
 export async function registerCommands(
   client: NeovimClient,

packages/app-talonjs/src/extension.ts

@@ -1,6 +1,6 @@
+import * as talon from "talon";
 import type { RunMode } from "@cursorless/lib-common";
 import { activate as activateCore } from "@cursorless/lib-talonjs-core";
-import * as talon from "talon";
 
 export async function activate(runMode: RunMode): Promise<void> {
   await activateCore(talon, runMode);

packages/app-vscode/src/InstallationDependencies.ts

@@ -1,10 +1,10 @@
-import { isWindows } from "@cursorless/lib-node-common";
-import { COMMAND_SERVER_EXTENSION_ID } from "@cursorless/lib-vscode-common";
-import glob from "fast-glob";
 import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
+import glob from "fast-glob";
 import * as vscode from "vscode";
+import { isWindows } from "@cursorless/lib-node-common";
+import { COMMAND_SERVER_EXTENSION_ID } from "@cursorless/lib-vscode-common";
 
 const STATE_KEY = "dontShowInstallationDependencies";
 

packages/app-vscode/src/ReleaseNotes.test.ts

@@ -1,9 +1,9 @@
 import * as sinon from "sinon";
+import type { ExtensionContext, Uri } from "vscode";
 import type { MessageType, Messages } from "@cursorless/lib-common";
 import { asyncSafety } from "@cursorless/lib-common";
-import type { ExtensionContext, Uri } from "vscode";
-import { ReleaseNotes, VERSION_KEY, WHATS_NEW } from "./ReleaseNotes";
 import type { VscodeApi } from "@cursorless/lib-vscode-common";
+import { ReleaseNotes, VERSION_KEY, WHATS_NEW } from "./ReleaseNotes";
 
 interface Input {
   /** Whether the VSCode window is focused */

packages/app-vscode/src/ReleaseNotes.ts

@@ -1,9 +1,9 @@
+import * as semver from "semver";
 import type { ExtensionContext } from "vscode";
+import { URI } from "vscode-uri";
 import type { Messages } from "@cursorless/lib-common";
 import { showInfo } from "@cursorless/lib-common";
-import * as semver from "semver";
 import type { VscodeApi } from "@cursorless/lib-vscode-common";
-import { URI } from "vscode-uri";
 
 /**
  * The key to use in global storage to detect when Cursorless version number has

packages/app-vscode/src/ScopeTreeProvider.ts

@@ -1,23 +1,3 @@
-import type {
-  CursorlessCommandId,
-  IDE,
-  ScopeProvider,
-  ScopeSupportInfo,
-  ScopeType,
-  ScopeTypeInfo,
-  Selection,
-  TextEditor,
-} from "@cursorless/lib-common";
-import {
-  CURSORLESS_SCOPE_TREE_VIEW_ID,
-  DOCS_URL,
-  ScopeSupport,
-  disposableFrom,
-  serializeScopeType,
-  uriEncodeHashId,
-} from "@cursorless/lib-common";
-import { type CustomSpokenFormGenerator } from "@cursorless/lib-engine";
-import { type VscodeApi } from "@cursorless/lib-vscode-common";
 import { isEqual } from "lodash-es";
 import type {
   Disposable,
@@ -38,6 +18,26 @@ import {
   window,
 } from "vscode";
 import { URI } from "vscode-uri";
+import type {
+  CursorlessCommandId,
+  IDE,
+  ScopeProvider,
+  ScopeSupportInfo,
+  ScopeType,
+  ScopeTypeInfo,
+  Selection,
+  TextEditor,
+} from "@cursorless/lib-common";
+import {
+  CURSORLESS_SCOPE_TREE_VIEW_ID,
+  DOCS_URL,
+  ScopeSupport,
+  disposableFrom,
+  serializeScopeType,
+  uriEncodeHashId,
+} from "@cursorless/lib-common";
+import { type CustomSpokenFormGenerator } from "@cursorless/lib-engine";
+import { type VscodeApi } from "@cursorless/lib-vscode-common";
 import type {
   ScopeVisualizer,
   VisualizationType,

packages/app-vscode/src/SpyWebviewView.ts

@@ -1,6 +1,6 @@
-import type { Disposable } from "@cursorless/lib-common";
 import { cloneDeep } from "lodash-es";
 import type { Uri, Webview, WebviewView } from "vscode";
+import type { Disposable } from "@cursorless/lib-common";
 import type { SpyWebViewEvent } from "@cursorless/lib-vscode-common";
 
 /**