Skip to content

Commit 4e5320a

Browse files
capJavertclaude
andcommitted
fix(auth): gate all visual changes behind onboarding v2 feature flag
- OnboardingRegistrationForm: MemberAlready style gated on flag + trigger - RegistrationForm: title gradient/size gated on flag - Both fall back to original v1 styles when flag is off Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 613f07d commit 4e5320a

3 files changed

Lines changed: 20 additions & 7 deletions

File tree

packages/shared/src/components/auth/OnboardingRegistrationForm.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,16 @@ import { providerMap } from './common';
55
import OrDivider from './OrDivider';
66
import { useLogContext } from '../../contexts/LogContext';
77
import type { AuthTriggersType } from '../../lib/auth';
8-
import { AuthEventNames } from '../../lib/auth';
8+
import { AuthEventNames, AuthTriggers } from '../../lib/auth';
99
import type { ButtonProps } from '../buttons/Button';
1010
import { Button, ButtonSize, ButtonVariant } from '../buttons/Button';
1111
import { isIOSNative } from '../../lib/func';
1212

1313
import { MemberAlready } from '../onboarding/MemberAlready';
1414
import SignupDisclaimer from './SignupDisclaimer';
1515
import { FunnelTargetId } from '../../features/onboarding/types/funnelEvents';
16+
import { useConditionalFeature } from '../../hooks/useConditionalFeature';
17+
import { featureOnboardingV2 } from '../../lib/featureManagement';
1618

1719
interface ClassName {
1820
onboardingSignup?: string;
@@ -105,6 +107,10 @@ export const OnboardingRegistrationForm = ({
105107
trigger,
106108
}: OnboardingRegistrationFormProps): ReactElement => {
107109
const { logEvent } = useLogContext();
110+
const { value: isOnboardingV2 } = useConditionalFeature({
111+
feature: featureOnboardingV2,
112+
shouldEvaluate: trigger === AuthTriggers.Onboarding,
113+
});
108114

109115
const trackOpenSignup = () => {
110116
logEvent({
@@ -157,8 +163,9 @@ export const OnboardingRegistrationForm = ({
157163
<MemberAlready
158164
onLogin={() => onExistingEmail?.('')}
159165
className={{
160-
container:
161-
'mx-auto mt-6 w-full justify-center border-t border-border-subtlest-tertiary pt-6 text-center text-text-secondary typo-callout',
166+
container: isOnboardingV2
167+
? 'mx-auto mt-6 w-full justify-center border-t border-border-subtlest-tertiary pt-6 text-center text-text-secondary typo-callout'
168+
: 'mx-auto mt-6 text-center text-text-secondary typo-callout',
162169
login: '!text-inherit',
163170
}}
164171
/>

packages/shared/src/components/auth/RegistrationForm.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ import {
3535
TypographyTag,
3636
TypographyType,
3737
} from '../typography/Typography';
38+
import { onboardingGradientClasses } from '../onboarding/common';
3839
import { useAuthData } from '../../contexts/AuthDataContext';
3940
import { authAtom } from '../../features/onboarding/store/onboarding.store';
4041
import { FunnelTargetId } from '../../features/onboarding/types/funnelEvents';
@@ -281,10 +282,16 @@ const RegistrationForm = ({
281282
variant={ButtonVariant.Secondary}
282283
/>
283284
<Typography
284-
className="mt-0.5 flex-1 text-text-primary"
285+
className={
286+
isOnboardingV2
287+
? 'mt-0.5 flex-1 text-text-primary'
288+
: classNames('mt-0.5 flex-1', onboardingGradientClasses)
289+
}
285290
tag={TypographyTag.H2}
286-
type={TypographyType.Title2}
287-
bold
291+
type={
292+
isOnboardingV2 ? TypographyType.Title2 : TypographyType.Title1
293+
}
294+
bold={isOnboardingV2}
288295
>
289296
Join daily.dev
290297
</Typography>

packages/webapp/pages/onboarding.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,6 @@ function Page(props: PageProps) {
370370
const { autoDismissNotifications } = useSettingsContext();
371371
const { value: isOnboardingV2 } = useConditionalFeature({
372372
feature: featureOnboardingV2,
373-
shouldEvaluate: true,
374373
});
375374

376375
if (isOnboardingV2) {

0 commit comments

Comments
 (0)