Skip to content

Commit 351cf2b

Browse files
committed
#118 simplify sample app
1 parent 2253b16 commit 351cf2b

10 files changed

Lines changed: 23 additions & 37 deletions

File tree

sample/src/main/java/com/danikula/videocache/sample/App.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ public static HttpProxyCacheServer getProxy(Context context) {
1818
}
1919

2020
private HttpProxyCacheServer newProxy() {
21-
return new HttpProxyCacheServer(this);
21+
return new HttpProxyCacheServer.Builder(this)
22+
.cacheDirectory(Utils.getVideoCacheDir(this))
23+
.build();
2224
}
2325
}

sample/src/main/java/com/danikula/videocache/sample/GalleryVideoFragment.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.danikula.videocache.sample;
22

3-
import android.content.Context;
43
import android.os.Handler;
54
import android.os.Message;
65
import android.support.v4.app.Fragment;
@@ -22,10 +21,7 @@
2221
@EFragment(R.layout.fragment_video)
2322
public class GalleryVideoFragment extends Fragment implements CacheListener {
2423

25-
private static final String LOG_TAG = "VideoFragment";
26-
2724
@FragmentArg String url;
28-
@FragmentArg String cachePath;
2925

3026
@InstanceState int position;
3127
@InstanceState boolean playerStarted;
@@ -37,14 +33,9 @@ public class GalleryVideoFragment extends Fragment implements CacheListener {
3733

3834
private final VideoProgressUpdater updater = new VideoProgressUpdater();
3935

40-
public static Fragment build(Context context, Video video) {
41-
return build(video.url, video.getCacheFile(context).getAbsolutePath());
42-
}
43-
44-
public static Fragment build(String url, String cachePath) {
36+
public static Fragment build(String url) {
4537
return GalleryVideoFragment_.builder()
4638
.url(url)
47-
.cachePath(cachePath)
4839
.build();
4940
}
5041

sample/src/main/java/com/danikula/videocache/sample/MenuActivity.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ void onListItemClicked(int position) {
4949
@Click(R.id.cleanCacheButton)
5050
void onClearCacheButtonClick() {
5151
try {
52-
Utils.cleanDirectory(getExternalCacheDir());
52+
53+
Utils.cleanVideoCacheDir(this);
5354
} catch (IOException e) {
5455
Log.e(null, "Error cleaning cache", e);
5556
Toast.makeText(this, "Error cleaning cache", Toast.LENGTH_LONG).show();

sample/src/main/java/com/danikula/videocache/sample/MultipleVideosActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ protected void onCreate(Bundle state) {
2323
private void addVideoFragment(Video video, int containerViewId) {
2424
getSupportFragmentManager()
2525
.beginTransaction()
26-
.add(containerViewId, VideoFragment.build(this, video))
26+
.add(containerViewId, VideoFragment.build(video.url))
2727
.commit();
2828
}
2929
}

sample/src/main/java/com/danikula/videocache/sample/SharedCacheActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ protected void onCreate(Bundle state) {
2323
private void addVideoFragment(Video video, int containerViewId) {
2424
getSupportFragmentManager()
2525
.beginTransaction()
26-
.add(containerViewId, VideoFragment.build(this, video))
26+
.add(containerViewId, VideoFragment.build(video.url))
2727
.commit();
2828
}
2929
}

sample/src/main/java/com/danikula/videocache/sample/SingleVideoActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ protected void onCreate(Bundle state) {
1515
if (state == null) {
1616
getSupportFragmentManager()
1717
.beginTransaction()
18-
.add(R.id.containerView, VideoFragment.build(this, Video.ORANGE_1))
18+
.add(R.id.containerView, VideoFragment.build(Video.ORANGE_1.url))
1919
.commit();
2020
}
2121
}

sample/src/main/java/com/danikula/videocache/sample/Utils.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.danikula.videocache.sample;
22

3+
import android.content.Context;
4+
35
import java.io.File;
46
import java.io.IOException;
57

@@ -10,7 +12,16 @@
1012
*/
1113
public class Utils {
1214

13-
public static void cleanDirectory(File file) throws IOException {
15+
public static File getVideoCacheDir(Context context) {
16+
return new File(context.getExternalCacheDir(), "video-cache");
17+
}
18+
19+
public static void cleanVideoCacheDir(Context context) throws IOException {
20+
File videoCacheDir = getVideoCacheDir(context);
21+
cleanDirectory(videoCacheDir);
22+
}
23+
24+
private static void cleanDirectory(File file) throws IOException {
1425
if (!file.exists()) {
1526
return;
1627
}

sample/src/main/java/com/danikula/videocache/sample/Video.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
package com.danikula.videocache.sample;
22

3-
import android.content.Context;
4-
5-
import java.io.File;
6-
73
public enum Video {
84

95
ORANGE_1(Config.ROOT + "orange1.mp4"),
@@ -18,10 +14,6 @@ public enum Video {
1814
this.url = url;
1915
}
2016

21-
public File getCacheFile(Context context) {
22-
return new File(context.getExternalCacheDir(), name());
23-
}
24-
2517
private class Config {
2618
private static final String ROOT = "https://raw.githubusercontent.com/danikula/AndroidVideoCache/master/files/";
2719
}

sample/src/main/java/com/danikula/videocache/sample/VideoFragment.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.danikula.videocache.sample;
22

3-
import android.content.Context;
43
import android.os.Handler;
54
import android.os.Message;
65
import android.support.v4.app.Fragment;
@@ -26,22 +25,16 @@ public class VideoFragment extends Fragment implements CacheListener {
2625
private static final String LOG_TAG = "VideoFragment";
2726

2827
@FragmentArg String url;
29-
@FragmentArg String cachePath;
3028

3129
@ViewById ImageView cacheStatusImageView;
3230
@ViewById VideoView videoView;
3331
@ViewById ProgressBar progressBar;
3432

3533
private final VideoProgressUpdater updater = new VideoProgressUpdater();
3634

37-
public static Fragment build(Context context, Video video) {
38-
return build(video.url, video.getCacheFile(context).getAbsolutePath());
39-
}
40-
41-
public static Fragment build(String url, String cachePath) {
35+
public static Fragment build(String url) {
4236
return VideoFragment_.builder()
4337
.url(url)
44-
.cachePath(cachePath)
4538
.build();
4639
}
4740

sample/src/main/java/com/danikula/videocache/sample/VideoGalleryActivity.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.danikula.videocache.sample;
22

3-
import android.content.Context;
43
import android.support.v4.app.Fragment;
54
import android.support.v4.app.FragmentActivity;
65
import android.support.v4.app.FragmentStatePagerAdapter;
@@ -27,17 +26,14 @@ void afterViewInjected() {
2726

2827
private static final class ViewsPagerAdapter extends FragmentStatePagerAdapter {
2928

30-
private final Context context;
31-
3229
public ViewsPagerAdapter(FragmentActivity activity) {
3330
super(activity.getSupportFragmentManager());
34-
this.context = activity;
3531
}
3632

3733
@Override
3834
public Fragment getItem(int position) {
3935
Video video = Video.values()[position];
40-
return GalleryVideoFragment.build(context, video);
36+
return GalleryVideoFragment.build(video.url);
4137
}
4238

4339
@Override

0 commit comments

Comments
 (0)