Skip to content

Commit 6cd1855

Browse files
committed
#132: format response headers in US locale to make sure library supports any language
1 parent 01bba67 commit 6cd1855

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

library/src/main/java/com/danikula/videocache/HttpProxyCache.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import java.io.IOException;
99
import java.io.OutputStream;
1010
import java.net.Socket;
11+
import java.util.Locale;
1112

1213
import static com.danikula.videocache.ProxyCacheUtils.DEFAULT_BUFFER_SIZE;
1314

@@ -65,9 +66,9 @@ private String newResponseHeaders(GetRequest request) throws IOException, ProxyC
6566
return new StringBuilder()
6667
.append(request.partial ? "HTTP/1.1 206 PARTIAL CONTENT\n" : "HTTP/1.1 200 OK\n")
6768
.append("Accept-Ranges: bytes\n")
68-
.append(lengthKnown ? String.format("Content-Length: %d\n", contentLength) : "")
69-
.append(addRange ? String.format("Content-Range: bytes %d-%d/%d\n", request.rangeOffset, length - 1, length) : "")
70-
.append(mimeKnown ? String.format("Content-Type: %s\n", mime) : "")
69+
.append(lengthKnown ? format("Content-Length: %d\n", contentLength) : "")
70+
.append(addRange ? format("Content-Range: bytes %d-%d/%d\n", request.rangeOffset, length - 1, length) : "")
71+
.append(mimeKnown ? format("Content-Type: %s\n", mime) : "")
7172
.append("\n") // headers end
7273
.toString();
7374
}
@@ -98,6 +99,10 @@ private void responseWithoutCache(OutputStream out, long offset) throws ProxyCac
9899
}
99100
}
100101

102+
private String format(String pattern, Object... args) {
103+
return String.format(Locale.US, pattern, args);
104+
}
105+
101106
@Override
102107
protected void onCachePercentsAvailableChanged(int percents) {
103108
if (listener != null) {

0 commit comments

Comments
 (0)