Skip to content

Commit 394b15b

Browse files
committed
Revert "change jdbcPluginName required to true for Mysql"
This reverts commit 2b806ad.
1 parent 2b806ad commit 394b15b

1 file changed

Lines changed: 2 additions & 17 deletions

File tree

mysql-plugin/src/main/java/io/cdap/plugin/mysql/MysqlConnectorConfig.java

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,9 @@
1616

1717
package io.cdap.plugin.mysql;
1818

19-
import io.cdap.cdap.api.annotation.Description;
20-
import io.cdap.cdap.api.annotation.Macro;
21-
import io.cdap.cdap.api.annotation.Name;
22-
import io.cdap.plugin.db.ConnectionConfig;
2319
import io.cdap.plugin.db.connector.AbstractDBSpecificConnectorConfig;
24-
import java.util.Properties;
25-
import javax.annotation.Nullable;
2620

21+
import java.util.Properties;
2722

2823
/**
2924
* Configuration for Mysql Connector
@@ -41,15 +36,10 @@ public MysqlConnectorConfig(String host, int port, String user, String password,
4136
this.port = port;
4237
this.user = user;
4338
this.password = password;
39+
this.jdbcPluginName = jdbcPluginName;
4440
this.connectionArguments = connectionArguments;
4541
}
4642

47-
@Name(ConnectionConfig.JDBC_PLUGIN_NAME)
48-
@Description("Name of the JDBC driver to use. This is the value of the 'jdbcPluginName' key defined in the JSON " +
49-
"file for the JDBC plugin.")
50-
@Macro
51-
private String jdbcPluginName;
52-
5343
@Override
5444
public String getConnectionString() {
5545
return String.format(MYSQL_CONNECTION_STRING_FORMAT, host, getPort());
@@ -60,11 +50,6 @@ public int getDefaultPort() {
6050
return 3306;
6151
}
6252

63-
@Override
64-
public String getJdbcPluginName() {
65-
return jdbcPluginName;
66-
}
67-
6853
@Override
6954
public Properties getConnectionArgumentsProperties() {
7055
Properties prop = super.getConnectionArgumentsProperties();

0 commit comments

Comments
 (0)