Skip to content

Commit dfdc3af

Browse files
removed database from connector spec
1 parent ec4be34 commit dfdc3af

6 files changed

Lines changed: 12 additions & 3 deletions

File tree

cloudsql-postgresql-plugin/src/main/java/io/cdap/plugin/cloudsql/postgres/CloudSQLPostgreSQLConnector.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ protected void setConnectorSpec(ConnectorSpecRequest request, DBConnectorPath pa
107107
.addRelatedPlugin(new PluginSpec(CloudSQLPostgreSQLConstants.PLUGIN_NAME,
108108
BatchSink.PLUGIN_TYPE, sinkProperties));
109109

110-
sinkProperties.put(ConnectionConfig.DATABASE, config.getDatabase());
111110
String schema = path.getSchema();
112111
if (schema != null) {
113112
sinkProperties.put(CloudSQLPostgreSQLSink.CloudSQLPostgreSQLSinkConfig.DB_SCHEMA_NAME, schema);

cloudsql-postgresql-plugin/widgets/CloudSQLPostgreSQL-batchsink.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,10 @@
185185
"type": "property",
186186
"name": "password"
187187
},
188+
{
189+
"type": "property",
190+
"name": "database"
191+
},
188192
{
189193
"type": "property",
190194
"name": "connectionArguments"

oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleConnector.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ protected void setConnectorSpec(ConnectorSpecRequest request, DBConnectorPath pa
8080
.addRelatedPlugin(new PluginSpec(OracleConstants.PLUGIN_NAME, BatchSource.PLUGIN_TYPE, sourceProperties))
8181
.addRelatedPlugin(new PluginSpec(OracleConstants.PLUGIN_NAME, BatchSink.PLUGIN_TYPE, sinkProperties));
8282

83-
sinkProperties.put(OracleConstants.NAME_DATABASE, config.getDatabase());
8483
String schema = path.getSchema();
8584
if (schema != null) {
8685
sinkProperties.put(OracleSink.OracleSinkConfig.DB_SCHEMA_NAME, schema);

oracle-plugin/widgets/Oracle-batchsink.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@
216216
{
217217
"type": "property",
218218
"name": "connectionArguments"
219+
},
220+
{
221+
"type": "property",
222+
"name": "database"
219223
}
220224
]
221225
},

postgresql-plugin/src/main/java/io/cdap/plugin/postgres/PostgresConnector.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ protected void setConnectorSpec(ConnectorSpecRequest request, DBConnectorPath pa
8181
.addRelatedPlugin(new PluginSpec(PostgresConstants.PLUGIN_NAME, BatchSource.PLUGIN_TYPE, sourceProperties))
8282
.addRelatedPlugin(new PluginSpec(PostgresConstants.PLUGIN_NAME, BatchSink.PLUGIN_TYPE, sinkProperties));
8383

84-
sinkProperties.put(PostgresConnectorConfig.NAME_DATABASE, config.getDatabase());
8584
String schema = path.getSchema();
8685
if (schema != null) {
8786
sinkProperties.put(PostgresSink.PostgresSinkConfig.DB_SCHEMA_NAME, schema);

postgresql-plugin/widgets/Postgres-batchsink.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,10 @@
157157
"type": "property",
158158
"name": "port"
159159
},
160+
{
161+
"type": "property",
162+
"name": "database"
163+
},
160164
{
161165
"type": "property",
162166
"name": "connectionArguments"

0 commit comments

Comments
 (0)