Skip to content

Commit bb009c8

Browse files
Merge pull request #1436 from data-integrations/release-0.23-ut-fix-cherry-pick
Bumping version to snapshot, Fixing intermittent failures for spanner unit tests
2 parents 08cf487 + c0f1044 commit bb009c8

2 files changed

Lines changed: 11 additions & 20 deletions

File tree

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
<groupId>io.cdap.plugin</groupId>
2222
<artifactId>google-cloud</artifactId>
23-
<version>0.23.2</version>
23+
<version>0.23.3-SNAPSHOT</version>
2424
<name>Google Cloud Plugins</name>
2525
<packaging>jar</packaging>
2626
<description>Plugins for Google Big Query</description>

src/test/java/io/cdap/plugin/gcp/spanner/connector/SpannerConnectorTest.java

Lines changed: 10 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -196,43 +196,34 @@ private void testBrowse(SpannerConnector connector) throws IOException {
196196
// browse project
197197
BrowseDetail detail = connector.browse(new MockConnectorContext(new MockConnectorConfigurer()),
198198
BrowseRequest.builder("/").build());
199-
BrowseDetail expected = BrowseDetail.builder()
200-
.setTotalCount(1)
201-
.addEntity(BrowseEntity.builder(instance, "/" + instance, "instance")
199+
BrowseEntity expected = BrowseEntity.builder(instance, "/" + instance, "instance")
202200
.canBrowse(true)
203201
.canSample(false)
204-
.build())
205-
.build();
206-
Assert.assertEquals(expected, detail);
202+
.build();
203+
Assert.assertTrue(detail.getEntities().contains(expected));
207204

208205
// browse instance
209206
detail = connector.browse(new MockConnectorContext(new MockConnectorConfigurer()),
210207
BrowseRequest.builder(instance).build());
211-
expected = BrowseDetail.builder()
212-
.setTotalCount(1)
213-
.addEntity(BrowseEntity.builder(database, String.format("/%s/%s", instance, database), "database")
208+
expected = BrowseEntity.builder(database, String.format("/%s/%s", instance, database), "database")
214209
.canBrowse(true)
215210
.canSample(false)
216-
.build())
217-
.build();
218-
Assert.assertEquals(expected, detail);
211+
.build();
212+
Assert.assertTrue(detail.getEntities().contains(expected));
219213

220214
// browse database
221215
detail = connector.browse(new MockConnectorContext(new MockConnectorConfigurer()),
222216
BrowseRequest.builder(instance + "/" + database).build());
223-
expected = BrowseDetail.builder()
224-
.setTotalCount(1)
225-
.addEntity(BrowseEntity.builder(table, String.format("/%s/%s/%s", instance, database, table), "table")
217+
expected = BrowseEntity.builder(table, String.format("/%s/%s/%s", instance, database, table), "table")
226218
.canBrowse(false)
227219
.canSample(true)
228-
.build())
229-
.build();
230-
Assert.assertEquals(expected, detail);
220+
.build();
221+
Assert.assertTrue(detail.getEntities().contains(expected));
231222

232223
// browse table
233224
detail = connector.browse(new MockConnectorContext(new MockConnectorConfigurer()),
234225
BrowseRequest.builder(instance + "/" + database + "/" + table).build());
235-
Assert.assertEquals(expected, detail);
226+
Assert.assertTrue(detail.getEntities().contains(expected));
236227

237228
// invalid path
238229
Assert.assertThrows(IllegalArgumentException.class, () ->

0 commit comments

Comments
 (0)