Peco 1016 (#157)

Author: nithinkdb

connection.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"database/sql/driver"
 	"fmt"
+	"strconv"
 	"time"
 
 	"github.com/databricks/databricks-sql-go/driverctx"
@@ -342,7 +343,7 @@ func (c *conn) executeStatement(ctx context.Context, query string, args []driver
 }
 
 func namedValuesToTSparkParams(args []driver.NamedValue) []*cli_service.TSparkParameter {
-	var ts []string = []string{"STRING", "DOUBLE", "BOOLEAN"}
+	var ts []string = []string{"STRING", "DOUBLE", "BOOLEAN", "TIMESTAMP", "FLOAT", "INTEGER", "TINYINT", "SMALLINT", "BIGINT"}
 	var params []*cli_service.TSparkParameter
 	for i := range args {
 		arg := args[i]
@@ -366,47 +367,51 @@ func namedValuesToTSparkParams(args []driver.NamedValue) []*cli_service.TSparkPa
 		case int:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[5]
 		case uint:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[5]
 		case int8:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[6]
 		case uint8:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[6]
 		case int16:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[7]
 		case uint16:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[7]
 		case int32:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[5]
 		case uint32:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[5]
 		case int64:
-			f := float64(t)
-			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			s := strconv.FormatInt(t, 10)
+			param.Value.StringValue = &s
+			param.Type = &ts[8]
 		case uint64:
-			f := float64(t)
-			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			s := strconv.FormatUint(t, 10)
+			param.Value.StringValue = &s
+			param.Type = &ts[8]
 		case float32:
 			f := float64(t)
 			param.Value.DoubleValue = &f
-			param.Type = &ts[1]
+			param.Type = &ts[4]
+		case time.Time:
+			s := t.String()
+			param.Value.StringValue = &s
+			param.Type = &ts[3]
 		default:
 			s := fmt.Sprintf("%s", arg.Value)
 			param.Value.StringValue = &s

statement_test.go

@@ -3,12 +3,14 @@ package dbsql
 import (
 	"context"
 	"database/sql/driver"
+	"testing"
+	"time"
+
 	"github.com/apache/thrift/lib/go/thrift"
 	"github.com/databricks/databricks-sql-go/internal/cli_service"
 	"github.com/databricks/databricks-sql-go/internal/client"
 	"github.com/databricks/databricks-sql-go/internal/config"
 	"github.com/stretchr/testify/assert"
-	"testing"
 )
 
 func TestStmt_Close(t *testing.T) {
@@ -164,3 +166,13 @@ func TestStmt_QueryContext(t *testing.T) {
 		assert.Equal(t, testQuery, savedQueryString)
 	})
 }
+func TestParameters(t *testing.T) {
+	t.Run("Parameter casting should be correct", func(t *testing.T) {
+		values := [3]driver.NamedValue{{Ordinal: 1, Name: "", Value: float32(5)}, {Ordinal: 2, Name: "", Value: time.Now()}, {Ordinal: 3, Name: "", Value: int64(5)}}
+		parameters := namedValuesToTSparkParams(values[:])
+		assert.Equal(t, &cli_service.TSparkParameterValue{DoubleValue: thrift.Float64Ptr(5)}, parameters[0].Value)
+		assert.NotNil(t, parameters[1].Value.StringValue)
+		assert.Equal(t, string("TIMESTAMP"), *parameters[1].Type)
+		assert.Equal(t, &cli_service.TSparkParameterValue{StringValue: strPtr("5")}, parameters[2].Value)
+	})
+}