Fix lint issues: gofmt, errcheck, and staticcheck

- Run gofmt -s on all telemetry files
- Add explicit error ignore for json.Encoder.Encode in tests
- Add comment to empty select case to fix SA9003 staticcheck warning

Author: samikshya-db

telemetry/config.go

@@ -48,7 +48,7 @@ type Config struct {
 // Clients can override by explicitly setting enableTelemetry=true/false.
 func DefaultConfig() *Config {
 	return &Config{
-		Enabled:                 false, // Will be set based on overlay logic
+		Enabled:                 false,                      // Will be set based on overlay logic
 		EnableTelemetry:         config.ConfigValue[bool]{}, // Unset = use server feature flag
 		BatchSize:               100,
 		FlushInterval:           5 * time.Second,
@@ -119,4 +119,3 @@ func isTelemetryEnabled(ctx context.Context, cfg *Config, host string, httpClien
 
 	return serverEnabled
 }
-

telemetry/config_test.go

@@ -211,7 +211,7 @@ func TestIsTelemetryEnabled_ClientOverrideEnabled(t *testing.T) {
 				"databricks.partnerplatform.clientConfigsFeatureFlags.enableTelemetryForGoDriver": false,
 			},
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 
@@ -245,7 +245,7 @@ func TestIsTelemetryEnabled_ClientOverrideDisabled(t *testing.T) {
 				"databricks.partnerplatform.clientConfigsFeatureFlags.enableTelemetryForGoDriver": true,
 			},
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 
@@ -277,7 +277,7 @@ func TestIsTelemetryEnabled_ServerEnabled(t *testing.T) {
 				"databricks.partnerplatform.clientConfigsFeatureFlags.enableTelemetryForGoDriver": true,
 			},
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 
@@ -309,7 +309,7 @@ func TestIsTelemetryEnabled_ServerDisabled(t *testing.T) {
 				"databricks.partnerplatform.clientConfigsFeatureFlags.enableTelemetryForGoDriver": false,
 			},
 		}
-		json.NewEncoder(w).Encode(resp)
+		_ = json.NewEncoder(w).Encode(resp)
 	}))
 	defer server.Close()
 

telemetry/exporter.go

@@ -20,14 +20,14 @@ type telemetryExporter struct {
 
 // telemetryMetric represents a metric to export.
 type telemetryMetric struct {
-	metricType      string
-	timestamp       time.Time
-	workspaceID     string
-	sessionID       string
-	statementID     string
-	latencyMs       int64
-	errorType       string
-	tags            map[string]interface{}
+	metricType  string
+	timestamp   time.Time
+	workspaceID string
+	sessionID   string
+	statementID string
+	latencyMs   int64
+	errorType   string
+	tags        map[string]interface{}
 }
 
 // telemetryPayload is the JSON structure sent to Databricks.
@@ -120,6 +120,7 @@ func (e *telemetryExporter) doExport(ctx context.Context, metrics []*telemetryMe
 			backoff := time.Duration(1<<uint(attempt-1)) * e.cfg.RetryDelay
 			select {
 			case <-time.After(backoff):
+				// Backoff completed, continue to retry
 			case <-ctx.Done():
 				return ctx.Err()
 			}

telemetry/exporter_test.go

@@ -296,8 +296,8 @@ func TestToExportedMetric_TagFiltering(t *testing.T) {
 
 func TestIsRetryableStatus(t *testing.T) {
 	tests := []struct {
-		status     int
-		retryable  bool
+		status      int
+		retryable   bool
 		description string
 	}{
 		{200, false, "200 OK is not retryable"},

telemetry/featureflag.go

@@ -33,12 +33,12 @@ type featureFlagCache struct {
 
 // featureFlagContext holds feature flag state and reference count for a host.
 type featureFlagContext struct {
-	mu            sync.RWMutex       // protects flags, lastFetched, fetching
-	flags         map[string]bool    // cached feature flags by name
-	lastFetched   time.Time          // when flags were last fetched
-	refCount      int                // protected by featureFlagCache.mu
-	cacheDuration time.Duration      // how long to cache flags
-	fetching      bool               // true if a fetch is in progress
+	mu            sync.RWMutex    // protects flags, lastFetched, fetching
+	flags         map[string]bool // cached feature flags by name
+	lastFetched   time.Time       // when flags were last fetched
+	refCount      int             // protected by featureFlagCache.mu
+	cacheDuration time.Duration   // how long to cache flags
+	fetching      bool            // true if a fetch is in progress
 }
 
 var (

telemetry/featureflag_test.go

@@ -441,4 +441,3 @@ func TestFetchFeatureFlags_ContextCancellation(t *testing.T) {
 		t.Error("Expected error for cancelled context")
 	}
 }
-