Skip to content

Commit db3f0f1

Browse files
committed
Changed dbsqlparam
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
1 parent 7ce81f6 commit db3f0f1

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

parameter_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212

1313
func TestParameter_Inference(t *testing.T) {
1414
t.Run("Should infer types correctly", func(t *testing.T) {
15-
values := [5]driver.NamedValue{{Name: "", Value: float32(5.1)}, {Name: "", Value: time.Now()}, {Name: "", Value: int64(5)}, {Name: "", Value: true}, {Name: "", Value: TypeValuePair{Value: "6.2", Type: Decimal}}}
15+
values := [5]driver.NamedValue{{Name: "", Value: float32(5.1)}, {Name: "", Value: time.Now()}, {Name: "", Value: int64(5)}, {Name: "", Value: true}, {Name: "", Value: DbSqlParam{Value: "6.2", Type: Decimal}}}
1616
parameters := convertNamedValuesToSparkParams(values[:])
1717
assert.Equal(t, strconv.FormatFloat(float64(5.1), 'f', -1, 64), *parameters[0].Value.StringValue)
1818
assert.NotNil(t, parameters[1].Value.StringValue)
@@ -24,7 +24,7 @@ func TestParameter_Inference(t *testing.T) {
2424
}
2525
func TestParameters_Names(t *testing.T) {
2626
t.Run("Should infer types correctly", func(t *testing.T) {
27-
values := [2]driver.NamedValue{{Name: "1", Value: int(26)}, {Name: "2", Value: TypeValuePair{Type: Decimal, Value: "6.2"}}}
27+
values := [2]driver.NamedValue{{Name: "1", Value: int(26)}, {Name: "2", Value: DbSqlParam{Type: Decimal, Value: "6.2"}}}
2828
parameters := convertNamedValuesToSparkParams(values[:])
2929
assert.Equal(t, string("1"), *parameters[0].Name)
3030
assert.Equal(t, cli_service.TSparkParameterValue{StringValue: strPtr("26")}, *parameters[0].Value)

parameters.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ type DbSqlParam struct {
1515
Value any
1616
}
1717

18-
type TypeValuePair struct {
19-
Type SqlType
20-
Value any
21-
}
22-
2318
type SqlType int64
2419

2520
const (
@@ -133,7 +128,7 @@ func inferTypes(params []DbSqlParam) {
133128
case time.Time:
134129
param.Value = value.String()
135130
param.Type = Timestamp
136-
case TypeValuePair:
131+
case DbSqlParam:
137132
param.Value = value.Value
138133
param.Type = value.Type
139134
default:

0 commit comments

Comments
 (0)