fix(logging): improve data quality across basket and API wide events

Add numeric duration_ms in drains, drop OPTIONS noise, return 204 for
bots, normalize flag fallbacks to empty string, set mcp_auth on success,
remove duplicate request_id, and add stack traces to process errors.

Author: izadoesdev

apps/api/src/index.ts

@@ -57,7 +57,9 @@ process.on("unhandledRejection", (reason, _promise) => {
 	captureError(reason);
 	log.error({
 		process: "unhandledRejection",
-		reason: reason instanceof Error ? reason.message : String(reason),
+		error: reason instanceof Error ? reason.message : String(reason),
+		error_stack: reason instanceof Error ? reason.stack : undefined,
+		error_source: "process",
 	});
 });
 
@@ -66,6 +68,8 @@ process.on("uncaughtException", (error) => {
 	log.error({
 		process: "uncaughtException",
 		error: error instanceof Error ? error.message : String(error),
+		error_stack: error instanceof Error ? error.stack : undefined,
+		error_source: "process",
 	});
 });
 

apps/api/src/lib/evlog-api.ts

@@ -34,11 +34,31 @@ const devFsDrain = useLocalEvlogFiles
 	? createFsDrain({ dir: devFsLogsDir, pretty: false })
 	: null;
 
+const DURATION_REGEX = /^([\d.]+)(ms|s)$/;
+
+function parseDurationMs(duration: unknown): number | undefined {
+	if (typeof duration !== "string") {
+		return undefined;
+	}
+	const match = duration.match(DURATION_REGEX);
+	if (!match?.[1]) {
+		return undefined;
+	}
+	return match[2] === "s"
+		? Math.round(Number.parseFloat(match[1]) * 1000)
+		: Math.round(Number.parseFloat(match[1]));
+}
+
 /**
  * In development, writes NDJSON wide events to `apps/api/.evlog/logs/` (analyze-logs skill)
  * and still sends to Axiom via the batched pipeline. Production: Axiom only.
  */
 export async function apiLoggerDrain(ctx: DrainContext): Promise<void> {
+	const durationMs = parseDurationMs(ctx.event.duration);
+	if (durationMs !== undefined) {
+		ctx.event.duration_ms = durationMs;
+	}
+
 	if (devFsDrain) {
 		await devFsDrain(ctx);
 	}

apps/api/src/routes/mcp.ts

@@ -70,6 +70,7 @@ export const mcp = new Elysia({ prefix: "/v1/mcp" })
 	})
 	.all("/", async ({ request, user, apiKey }) => {
 		mergeWideEvent({
+			mcp_auth: user ? "session" : "api_key",
 			mcp_session: Boolean(user),
 			mcp_api_key: Boolean(apiKey),
 		});

apps/api/src/routes/public/flags.ts

@@ -483,11 +483,11 @@ export const flagsRoute = new Elysia({ prefix: "/v1/flags" })
 		"/evaluate",
 		async function evaluateFlagEndpoint({ query, set }) {
 			mergeWideEvent({
-				flag_key: query.key || "missing",
-				flag_client_id: query.clientId || "missing",
+				flag_key: query.key || "",
+				flag_client_id: query.clientId || "",
 				flag_has_user_id: Boolean(query.userId),
 				flag_has_email: Boolean(query.email),
-				flag_environment: query.environment || "missing",
+				flag_environment: query.environment || "",
 			});
 
 			try {
@@ -557,10 +557,10 @@ export const flagsRoute = new Elysia({ prefix: "/v1/flags" })
 		async function bulkEvaluateFlags({ query, set }) {
 			mergeWideEvent({
 				flag_bulk: true,
-				flag_client_id: query.clientId || "missing",
+				flag_client_id: query.clientId || "",
 				flag_has_user_id: Boolean(query.userId),
 				flag_has_email: Boolean(query.email),
-				flag_environment: query.environment || "missing",
+				flag_environment: query.environment || "",
 			});
 
 			try {
@@ -633,8 +633,8 @@ export const flagsRoute = new Elysia({ prefix: "/v1/flags" })
 		"/definitions",
 		async function getDefinitionsEndpoint({ query, set }) {
 			mergeWideEvent({
-				flag_client_id: query.clientId || "missing",
-				flag_environment: query.environment || "missing",
+				flag_client_id: query.clientId || "",
+				flag_environment: query.environment || "",
 			});
 
 			try {

apps/api/src/routes/query.ts

@@ -973,7 +973,6 @@ export const query = new Elysia({ prefix: "/v1/query" })
 			mergeWideEvent({
 				websites_count: count,
 				auth_method: ctx.authMethod,
-				request_id: requestId,
 			});
 			return { success: true, requestId, websites: list, total: count };
 		})()
@@ -1090,7 +1089,6 @@ export const query = new Elysia({ prefix: "/v1/query" })
 				mergeWideEvent({
 					query_is_batch: isBatch,
 					query_count: isBatch ? body.length : 1,
-					request_id: requestId,
 				});
 
 				if (isBatch) {

apps/basket/src/index.ts

@@ -31,7 +31,9 @@ process.on("unhandledRejection", (reason, _promise) => {
 	captureError(reason);
 	log.error({
 		process: "unhandledRejection",
-		reason: reason instanceof Error ? reason.message : String(reason),
+		error: reason instanceof Error ? reason.message : String(reason),
+		error_stack: reason instanceof Error ? reason.stack : undefined,
+		error_source: "process",
 	});
 });
 
@@ -40,6 +42,8 @@ process.on("uncaughtException", (error) => {
 	log.error({
 		process: "uncaughtException",
 		error: error instanceof Error ? error.message : String(error),
+		error_stack: error instanceof Error ? error.stack : undefined,
+		error_source: "process",
 	});
 });
 

apps/basket/src/lib/evlog-basket.ts

@@ -37,11 +37,35 @@ const devFsDrain = useLocalEvlogFiles
 	? createFsDrain({ dir: devFsLogsDir, pretty: false })
 	: null;
 
+const DURATION_MS_REGEX = /^([\d.]+)(ms|s)$/;
+
+function parseDurationMs(duration: unknown): number | undefined {
+	if (typeof duration !== "string") {
+		return undefined;
+	}
+	const match = duration.match(DURATION_MS_REGEX);
+	if (!match?.[1]) {
+		return undefined;
+	}
+	return match[2] === "s"
+		? Math.round(Number.parseFloat(match[1]) * 1000)
+		: Math.round(Number.parseFloat(match[1]));
+}
+
 /**
  * In development, writes NDJSON wide events to `apps/basket/.evlog/logs/` (analyze-logs skill)
  * and still sends to Axiom via the batched pipeline. Production: Axiom only.
  */
 export async function basketLoggerDrain(ctx: DrainContext): Promise<void> {
+	if (ctx.event.method === "OPTIONS") {
+		return;
+	}
+
+	const durationMs = parseDurationMs(ctx.event.duration);
+	if (durationMs !== undefined) {
+		ctx.event.duration_ms = durationMs;
+	}
+
 	if (devFsDrain) {
 		await devFsDrain(ctx);
 	}

apps/basket/src/lib/request-validation.ts

@@ -307,10 +307,7 @@ export function checkForBot(
 			);
 
 			return {
-				error: new Response(JSON.stringify({ status: "ignored" }), {
-					status: 200,
-					headers: { "Content-Type": "application/json" },
-				}),
+				error: new Response(null, { status: 204 }),
 			};
 		}
 
@@ -325,10 +322,7 @@ export function checkForBot(
 		);
 
 		return {
-			error: new Response(JSON.stringify({ status: "ignored" }), {
-				status: 200,
-				headers: { "Content-Type": "application/json" },
-			}),
+			error: new Response(null, { status: 204 }),
 		};
 	});
 }