Skip to content

Commit c52cc64

Browse files
authored
Merge pull request #20 from dataiku/bug/sc-84465-next-page-url-pagination-ko
`next page url` pagination not working with single token path
2 parents 805e14d + 113216e commit c52cc64

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

python-lib/pagination.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def update_next_page(self, data, response_links=None):
7575
self.is_last_batch_empty = True
7676
else:
7777
batch_size = 1
78-
if self.next_page_key and (len(self.next_page_key) > 1):
78+
if self.next_page_key and (len(self.next_page_key) > 0):
7979
self.next_page_url = self.get_from_path(data, self.next_page_key)
8080
if self.skip_key:
8181
self.skip = data.get(self.skip_key)

python-lib/rest_api_client.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ def template_dict(dictionnary, **kwargs):
1818
ret[key] = template_dict(ret[key], **kwargs)
1919
if isinstance(ret[key], str):
2020
ret[key] = format_template(ret[key], **kwargs)
21-
return ret
2221
return ret
2322

2423

tests/python/integration/test_scenario.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,7 @@ def test_run_api_connect_array_api(user_dss_clients):
2525

2626
def test_run_api_connect_search_path(user_dss_clients):
2727
dss_scenario.run(user_dss_clients, project_key=TEST_PROJECT_KEY, scenario_id="SearchPath")
28+
29+
30+
def test_run_api_connect_check_sc_84465(user_dss_clients):
31+
dss_scenario.run(user_dss_clients, project_key=TEST_PROJECT_KEY, scenario_id="CHECKSC84465")

0 commit comments

Comments
 (0)