Skip to content

Commit f80ccdc

Browse files
committed
Improving comments on pagination edge cases
1 parent 339e1b6 commit f80ccdc

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

python-lib/pagination.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,8 +124,10 @@ def has_next_page(self):
124124
return True
125125
else:
126126
if self.data_is_list:
127+
# for lists is_last_batch_empty is set correctly and handled by the code above
127128
return True
128-
# No way to know if the last batch was empty so we stop here
129+
# Without a counting_key we have no mean to know if the last batch was empty.
130+
# To avoid infinite loop we stop pagination here
129131
return False
130132
return False
131133

0 commit comments

Comments
 (0)