Remove mypy

Author: kracekumar

.github/workflows/typecheck.yml

@@ -31,8 +31,7 @@ jobs:
       - name: Install dependencies
         run: uv sync --all-extras
 
-      - name: Run mypy
+      - name: Run ty
         run: |
           cd litecli
-          uv run --no-sync --frozen -- python -m ensurepip
-          uv run --no-sync --frozen -- python -m mypy --no-pretty --install-types --non-interactive .
+          uv run ty check -v

pyproject.toml

@@ -11,7 +11,6 @@ dependencies = [
     "cli-helpers[styles]>=2.2.1",
     "click>=4.1,!=8.1.*",
     "configobj>=5.0.5",
-    "mypy>=1.17.1",
     "prompt-toolkit>=3.0.3,<4.0.0",
     "pygments>=1.6",
     "sqlparse>=0.4.4",
@@ -58,38 +57,6 @@ litecli = ["liteclirc", "AUTHORS"]
 [tool.ruff]
 line-length = 140
 
-[tool.mypy]
-pretty = true
-strict_equality = true
-ignore_missing_imports = true
-warn_unreachable = true
-warn_redundant_casts = true
-warn_no_return = true
-warn_unused_configs = true
-show_column_numbers = true
-show_error_codes = true
-warn_unused_ignores = true
-python_version = "3.9"
-# Resolve module discovery reliably
-explicit_package_bases = true
-packages = ["litecli"]
-# Gradually tighten typing
-disallow_incomplete_defs = true
-disallow_untyped_defs = true
-no_implicit_optional = true
-warn_return_any = true
-exclude = [
-    '^build/',
-    '^dist/',
-    '^\.tox/',
-    '^\.venv/',
-    '^venv/',
-    '^\.mypy_cache/',
-    '^\.pytest_cache/',
-    '^\.ruff_cache/',
-]
-
-
 [tool.ty.environment]
 python-version = "3.9"
 root = [".", "litecli", "litecli/packages", "litecli/packages/special"]
@@ -103,6 +70,5 @@ exclude = [
     '**/.venv/',
     '**/.mypy_cache/',
     '**/.pytest_cache/',
-    '**/.ruff_cache/',
-    '**/tests/**'
+    '**/.ruff_cache/'
 ]

tests/conftest.py

@@ -1,14 +1,13 @@
-# mypy: ignore-errors
-
 from __future__ import print_function
 
 import os
 
 import pytest
-from utils import create_db, db_connection, drop_tables
 
 import litecli.sqlexecute
 
+from .utils import create_db, db_connection, drop_tables
+
 
 @pytest.fixture(scope="function")
 def connection():

tests/test_clistyle.py

@@ -1,9 +1,8 @@
 # -*- coding: utf-8 -*-
-# mypy: ignore-errors
+
 """Test the litecli.clistyle module."""
 
 import pytest
-
 from pygments.style import Style
 from pygments.token import Token
 
@@ -17,7 +16,7 @@ def test_style_factory():
     cli_style = {"Token.Output.Header": header}
     style = style_factory("default", cli_style)
 
-    assert isinstance(style(), Style)
+    assert isinstance(style, Style)
     assert Token.Output.Header in style.styles
     assert header == style.styles[Token.Output.Header]
 
@@ -27,4 +26,4 @@ def test_style_factory_unknown_name():
     """Test that an unrecognized name will not throw an error."""
     style = style_factory("foobar", {})
 
-    assert isinstance(style(), Style)
+    assert isinstance(style, Style)

tests/test_completion_engine.py

@@ -1,7 +1,6 @@
-# mypy: ignore-errors
+import pytest
 
 from litecli.packages.completion_engine import suggest_type
-import pytest
 
 
 def sorted_dicts(dicts):

tests/test_completion_refresher.py

@@ -1,9 +1,8 @@
-# mypy: ignore-errors
-
 import time
-import pytest
 from unittest.mock import Mock, patch
 
+import pytest
+
 
 @pytest.fixture
 def refresher():

tests/test_dbspecial.py

@@ -1,21 +1,19 @@
-# mypy: ignore-errors
-
-from test_completion_engine import sorted_dicts
-from utils import assert_result_equal, dbtest, run
-
 from litecli.packages.completion_engine import suggest_type
 from litecli.packages.special.utils import check_if_sqlitedotcommand, format_uptime
 
+from .test_completion_engine import sorted_dicts
+from .utils import assert_result_equal, dbtest, run
+
 
 def test_import_first_argument():
-    test_cases = [
+    test_cases: list[tuple[str, int]] = [
         # text, expecting_arg_idx
-        [".import ", 1],
-        [".import ./da", 1],
-        [".import ./data.csv ", 2],
-        [".import ./data.csv t", 2],
-        [".import ./data.csv `t", 2],
-        ['.import ./data.csv "t', 2],
+        (".import ", 1),
+        (".import ./da", 1),
+        (".import ./data.csv ", 2),
+        (".import ./data.csv t", 2),
+        (".import ./data.csv `t", 2),
+        ('.import ./data.csv "t', 2),
     ]
     for text, expecting_arg_idx in test_cases:
         suggestions = suggest_type(text, text)
@@ -53,20 +51,14 @@ def test_list_or_show_create_tables():
 
 
 def test_format_uptime():
-    seconds = 59
-    assert "59 sec" == format_uptime(seconds)
-
-    seconds = 120
-    assert "2 min 0 sec" == format_uptime(seconds)
-
-    seconds = 54890
-    assert "15 hours 14 min 50 sec" == format_uptime(seconds)
-
-    seconds = 598244
-    assert "6 days 22 hours 10 min 44 sec" == format_uptime(seconds)
-
-    seconds = 522600
-    assert "6 days 1 hour 10 min 0 sec" == format_uptime(seconds)
+    for seconds, human_readable_text in [
+        ("59", "59 sec"),
+        ("120", "2 min 0 sec"),
+        ("54890", "15 hours 14 min 50 sec"),
+        ("598244", "6 days 22 hours 10 min 44 sec"),
+        ("522600", "6 days 1 hour 10 min 0 sec"),
+    ]:
+        assert human_readable_text == format_uptime(seconds)
 
 
 def test_indexes():

tests/test_llm_special.py

@@ -1,8 +1,8 @@
-# mypy: ignore-errors
+from unittest.mock import patch
 
 import pytest
-from unittest.mock import patch
-from litecli.packages.special.llm import handle_llm, FinishIteration, USAGE
+
+from litecli.packages.special.llm import USAGE, FinishIteration, handle_llm
 
 
 @patch("litecli.packages.special.llm.llm")

tests/test_main.py

@@ -1,5 +1,3 @@
-# mypy: ignore-errors
-
 import os
 import shutil
 from collections import namedtuple
@@ -10,11 +8,13 @@
 import click
 import pytest
 from click.testing import CliRunner
-from utils import create_db, db_connection, dbtest, run
+from prompt_toolkit import PromptSession
 
 from litecli.main import LiteCli, cli
 from litecli.packages.special.main import COMMANDS as SPECIAL_COMMANDS
 
+from .utils import create_db, db_connection, dbtest, run
+
 test_dir = os.path.abspath(os.path.dirname(__file__))
 project_dir = os.path.dirname(test_dir)
 default_config_file = os.path.join(project_dir, "tests", "liteclirc")
@@ -137,6 +137,7 @@ def test_help_strings_end_with_periods():
     for param in cli.params:
         if isinstance(param, click.core.Option):
             assert hasattr(param, "help")
+            assert isinstance(param.help, str)
             assert param.help.endswith(".")
 
 
@@ -160,7 +161,7 @@ class TestExecute:
         def server_type(self):
             return ["test"]
 
-    class PromptBuffer:
+    class PromptBuffer(PromptSession):
         output = TestOutput()
 
     m.prompt_app = PromptBuffer()
@@ -268,6 +269,7 @@ def test_import_command(executor):
 
 def test_startup_commands(executor):
     m = LiteCli(liteclirc=default_config_file)
+    assert m.startup_commands
     assert m.startup_commands["commands"] == [
         "create table startupcommands(a text)",
         "insert into startupcommands values('abc')",
@@ -328,7 +330,8 @@ def test_get_prompt(mock_datetime):
     assert lc.get_prompt(r"\s") == "42"
 
     # 11. Test when dbname is None => (none)
-    lc.connect(None)  # Simulate no DB connection
+    lc.connect(None)  # ty: ignore[invalid-argument-type]
+    # Simulate no DB connection and incorrect argument type
     assert lc.get_prompt(r"\d") == "(none)"
     assert lc.get_prompt(r"\f") == "(none)"
 

tests/test_parseutils.py

@@ -1,11 +1,10 @@
-# mypy: ignore-errors
-
 import pytest
+
 from litecli.packages.parseutils import (
     extract_tables,
-    query_starts_with,
-    queries_start_with,
     is_destructive,
+    queries_start_with,
+    query_starts_with,
 )