Fix connection leak, tighten socket-dir assertion, fix Windows start

- assert_executor_start_stop: capture conn returned by retry() and call
  conn.close() so the readiness backend session is released promptly
  instead of waiting for GC.

- test_executor_with_special_chars_in_all_paths: strengthen the Unix
  unix_socket_directories assertion to include the actual socket_dir
  path value, so a missing or mis-quoted path fails the test.

- PostgreSQLExecutor.start(): on Windows, run pg_ctl start -w
  synchronously via shell=True rather than delegating to mirakuru's
  subprocess polling.  pg_ctl exits as soon as the server is ready, so
  mirakuru's check_subprocess loop always sees a dead launcher process
  and times out; bypassing it removes the 60-second timeout failure
  seen in test_noproc_cached_version and related Windows CI jobs.

Made-with: Cursor

Author: tboy1337

pytest_postgresql/executor.py

@@ -176,6 +176,20 @@ def start(self: T) -> T:
                 f"The currently installed version of PostgreSQL: {self.version}."
             )
         self.init_directory()
+        if platform.system() == "Windows":
+            # On Windows, pg_ctl start -w exits as soon as the server is
+            # accepting connections.  mirakuru's polling loop calls
+            # check_subprocess() (our pg_ctl-status override) repeatedly
+            # while waiting for the launcher subprocess to indicate readiness,
+            # but by the time polling begins the launcher has already exited
+            # so the loop never sees a live process and times out.
+            # Running the command synchronously via the shell lets cmd.exe
+            # handle quoting and lets pg_ctl itself act as the readiness
+            # barrier, which is more reliable than mirakuru's approach here.
+            result = subprocess.run(self.command, shell=True, check=False)
+            if result.returncode != 0:
+                raise ProcessFinishedWithError(self, result.returncode)
+            return self
         return super().start()
 
     def clean_directory(self) -> None:

tests/test_executor.py

@@ -27,7 +27,7 @@ def assert_executor_start_stop(executor: PostgreSQLExecutor) -> None:
         # becomes accessible before PostgreSQL finishes database recovery,
         # so an immediate connect may raise OperationalError with
         # "the database system is starting up".
-        retry(
+        conn = retry(
             lambda: psycopg.connect(
                 dbname=executor.user,
                 user=executor.user,
@@ -37,6 +37,7 @@ def assert_executor_start_stop(executor: PostgreSQLExecutor) -> None:
             ),
             possible_exception=psycopg.OperationalError,
         )
+        conn.close()
         with pytest.raises(psycopg.OperationalError):
             psycopg.connect(
                 dbname=executor.user,
@@ -233,7 +234,7 @@ def test_executor_with_special_chars_in_all_paths(
     if current_platform == "Windows":
         assert "unix_socket_directories" not in executor.command
     else:
-        assert "unix_socket_directories='" in executor.command
+        assert f"unix_socket_directories='{socket_dir}'" in executor.command
 
     # Start and stop the executor to verify it works
     assert_executor_start_stop(executor)