Update invalidSchema action with support for all Dev Proxy schemas. Closes #168

Closes #168

Author: garrytrinder

CHANGELOG.md

@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Snippets: All snippets that reference schemas updated to use `v2.1.0` schema
 - Diagnostics: Improved highlighting to target specific nodes instead of entire objects
 - Diagnostics: All diagnostics now use unique codes for better identification
+- Quick Fixes: Update schema action now supports all Dev Proxy file schemas, not just config files
 
 ### Fixed:
 

src/code-actions.ts

@@ -85,6 +85,10 @@ function registerInvalidSchemaFixes(
         return;
       }
 
+      // Extract the schema filename from the current schema URL
+      const currentSchemaText = document.getText(diagnostic.range);
+      const schemaFilename = extractSchemaFilename(currentSchemaText);
+
       const fix = new vscode.CodeAction(
         'Update schema',
         vscode.CodeActionKind.QuickFix,
@@ -93,7 +97,7 @@ function registerInvalidSchemaFixes(
       fix.edit.replace(
         document.uri,
         diagnostic.range,
-        `https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v${devProxyVersion}/rc.schema.json`,
+        `https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v${devProxyVersion}/${schemaFilename}`,
       );
       fix.isPreferred = true;
       return [fix];
@@ -103,6 +107,27 @@ function registerInvalidSchemaFixes(
   registerJsonCodeActionProvider(context, invalidSchema);
 }
 
+/**
+ * Extract the schema filename from a schema URL.
+ * Returns the filename (e.g., 'mockresponseplugin.mocksfile.schema.json') 
+ * or defaults to 'rc.schema.json' if extraction fails.
+ */
+export function extractSchemaFilename(schemaUrl: string): string {
+  const defaultSchema = 'rc.schema.json';
+  
+  try {
+    // Match any .schema.json filename at the end of the URL
+    const match = schemaUrl.match(/([^/]+\.schema\.json)/i);
+    if (match) {
+      return match[1];
+    }
+  } catch {
+    // Fall through to default
+  }
+  
+  return defaultSchema;
+}
+
 function registerDeprecatedPluginPathFixes(context: vscode.ExtensionContext) {
   const correctPluginPath = '~appFolder/plugins/DevProxy.Plugins.dll';
 

src/test/code-actions.test.ts

@@ -5,7 +5,7 @@
 import * as assert from 'assert';
 import * as sinon from 'sinon';
 import * as vscode from 'vscode';
-import { registerCodeActions } from '../code-actions';
+import { registerCodeActions, extractSchemaFilename } from '../code-actions';
 import { getExtensionContext, createDevProxyInstall, getFixturePath } from './helpers';
 import { DiagnosticCodes } from '../constants';
 import { getDiagnosticCode, sleep } from '../utils';
@@ -533,3 +533,59 @@ suite('Code Action Provider Registration', () => {
     registerCodeActions(contextWithInstall);
   });
 });
+
+suite('extractSchemaFilename', () => {
+  test('should extract rc.schema.json from config file schema URL', () => {
+    const url = 'https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v0.29.0/rc.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'rc.schema.json');
+  });
+
+  test('should extract mockresponseplugin.mocksfile.schema.json from mocks file schema URL', () => {
+    const url = 'https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v0.24.0/mockresponseplugin.mocksfile.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'mockresponseplugin.mocksfile.schema.json');
+  });
+
+  test('should extract crudapiplugin.apifile.schema.json from CRUD API file schema URL', () => {
+    const url = 'https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v2.1.0/crudapiplugin.apifile.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'crudapiplugin.apifile.schema.json');
+  });
+
+  test('should extract rewriteplugin.rewritesfile.schema.json from rewrites file schema URL', () => {
+    const url = 'https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v0.25.0/rewriteplugin.rewritesfile.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'rewriteplugin.rewritesfile.schema.json');
+  });
+
+  test('should extract genericrandomerrorplugin.errorsfile.schema.json', () => {
+    const url = 'https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v2.0.0/genericrandomerrorplugin.errorsfile.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'genericrandomerrorplugin.errorsfile.schema.json');
+  });
+
+  test('should extract ratelimitingplugin.customresponsefile.schema.json', () => {
+    const url = 'https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v1.0.0/ratelimitingplugin.customresponsefile.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'ratelimitingplugin.customresponsefile.schema.json');
+  });
+
+  test('should return default rc.schema.json for URL without .schema.json', () => {
+    const url = 'https://example.com/some/path/file.json';
+    assert.strictEqual(extractSchemaFilename(url), 'rc.schema.json');
+  });
+
+  test('should return default rc.schema.json for empty string', () => {
+    assert.strictEqual(extractSchemaFilename(''), 'rc.schema.json');
+  });
+
+  test('should return default rc.schema.json for malformed URL', () => {
+    const url = 'not-a-valid-url';
+    assert.strictEqual(extractSchemaFilename(url), 'rc.schema.json');
+  });
+
+  test('should handle schema URL from old microsoft org', () => {
+    const url = 'https://raw.githubusercontent.com/microsoft/dev-proxy/main/schemas/v0.20.0/mockresponseplugin.schema.json';
+    assert.strictEqual(extractSchemaFilename(url), 'mockresponseplugin.schema.json');
+  });
+
+  test('should be case-insensitive for .schema.json extension', () => {
+    const url = 'https://example.com/path/MyPlugin.SCHEMA.JSON';
+    assert.strictEqual(extractSchemaFilename(url), 'MyPlugin.SCHEMA.JSON');
+  });
+});