Skip to content

Commit 133ac8e

Browse files
committed
fix: remove double error reporting in merge docker wrappers
createMultiPlatformImage was calling setResult/setFailed with the detailed error, then main.ts overwrote it with a generic message. Now docker.ts logs the detail and main.ts is the single source of truth for task failure status.
1 parent 4f0745c commit 133ac8e

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

azdo-task/DevcontainersMerge/src/docker.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import * as task from 'azure-pipelines-task-lib/task';
21
import * as docker from '../../../common/src/docker';
32
import {exec} from './exec';
43

@@ -20,7 +19,7 @@ export async function createMultiPlatformImage(
2019
);
2120
return true;
2221
} catch (error) {
23-
task.setResult(task.TaskResult.Failed, `${error}`);
22+
console.error(`${error}`);
2423
return false;
2524
}
2625
}

merge/src/docker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export async function createMultiPlatformImage(
2121
);
2222
return true;
2323
} catch (error) {
24-
core.setFailed(error);
24+
core.error(String(error));
2525
return false;
2626
} finally {
2727
core.endGroup();

0 commit comments

Comments
 (0)