Skip to content

Commit 023e5a4

Browse files
authored
add new actions job for 'features-registry-compatibility' to separate tests that do and do not have access to secrets'
1 parent 99b5f09 commit 023e5a4

1 file changed

Lines changed: 31 additions & 2 deletions

File tree

.github/workflows/dev-containers.yml

Lines changed: 31 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ jobs:
5656
"src/test/cli.up.test.ts",
5757
"src/test/imageMetadata.test.ts",
5858
"src/test/container-features/containerFeaturesOCIPush.test.ts",
59-
"src/test/container-features/registryCompatibilityOCI.test.ts",
6059
# Run all except the above:
6160
"--exclude src/test/container-features/registryCompatibilityOCI.test.ts --exclude src/test/container-features/containerFeaturesOCIPush.test.ts --exclude src/test/container-features/e2e.test.ts --exclude src/test/container-features/featuresCLICommands.test.ts --exclude src/test/container-features/containerFeaturesOrder.test.ts --exclude src/test/cli.build.test.ts --exclude src/test/cli.exec.buildKit.1.test.ts --exclude src/test/cli.exec.buildKit.2.test.ts --exclude src/test/cli.exec.nonBuildKit.1.test.ts --exclude src/test/cli.exec.nonBuildKit.2.test.ts --exclude src/test/cli.test.ts --exclude src/test/cli.up.test.ts --exclude src/test/imageMetadata.test.ts 'src/test/**/*.test.ts'",
6261
]
@@ -79,10 +78,40 @@ jobs:
7978
run: yarn test-matrix --forbid-only ${{ matrix.mocha-args }}
8079
env:
8180
CI: true
81+
82+
features-registry-compatibility:
83+
name: OCI Implementation Registry Compatibility
84+
# TODO: This should be expanded to run on different platforms
85+
# Most notably to test platform-specific credential helper behavior
86+
runs-on: ubuntu-latest
87+
steps:
88+
- name: Checkout
89+
uses: actions/checkout@v2
90+
- name: Setup Node.js
91+
uses: actions/setup-node@v1
92+
with:
93+
node-version: '16.x'
94+
registry-url: 'https://npm.pkg.github.com'
95+
scope: '@microsoft'
96+
- name: Install Dependencies
97+
run: yarn install --frozen-lockfile
98+
- name: Type-Check
99+
run: yarn type-check
100+
- name: Package
101+
run: yarn package
102+
- name: Run Tests
103+
run: yarn test-matrix --forbid-only src/test/container-features/registryCompatibilityOCI.test.ts
104+
env:
105+
CI: true
106+
# This variable should only be set in the parent `devcontainers/cli` repo.
82107
RUNNING_IN_DEVCONTAINERS_CLI_REPO_CI: ${{ vars.RUNNING_IN_DEVCONTAINERS_CLI_REPO_CI }}
108+
# Scoped to read private packages in the `devcontainers` org (for testing purposes)
109+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
110+
111+
83112
tests:
84113
name: Tests
85-
needs: tests-matrix
114+
needs: [tests-matrix, features-registry-compatibility]
86115
runs-on: ubuntu-latest
87116
steps:
88117
- name: Done

0 commit comments

Comments
 (0)