Skip to content

Commit 5155e99

Browse files
committed
fixup
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
1 parent ea9d22f commit 5155e99

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

controllers/workspace/devworkspace_controller.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ func (r *DevWorkspaceReconciler) Reconcile(ctx context.Context, req ctrl.Request
264264
K8sClient: r.Client,
265265
HttpClient: httpClient,
266266
DefaultResourceRequirements: workspace.Config.Workspace.DefaultContainerResources,
267-
ResourceCaps: workspace.Config.Workspace.ContainerResourceCaps,
268267
}
269268

270269
if wsDefaults.NeedsDefaultTemplate(workspace) {
@@ -358,7 +357,6 @@ func (r *DevWorkspaceReconciler) Reconcile(ctx context.Context, req ctrl.Request
358357
Image: workspace.Config.Workspace.ProjectCloneConfig.Image,
359358
Env: env.GetEnvironmentVariablesForProjectClone(workspace),
360359
Resources: workspace.Config.Workspace.ProjectCloneConfig.Resources,
361-
Caps: workspace.Config.Workspace.ContainerResourceCaps,
362360
}
363361
if workspace.Config.Workspace.ProjectCloneConfig.ImagePullPolicy != "" {
364362
projectCloneOptions.PullPolicy = config.Workspace.ProjectCloneConfig.ImagePullPolicy

pkg/library/resources/helper.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -166,21 +166,21 @@ func ApplyDefaults(resources, defaults *corev1.ResourceRequirements) *corev1.Res
166166
}
167167

168168
// Set default limits if not present
169-
for resourceName, quantity := range defaults.Limits {
169+
for resource, quantity := range defaults.Limits {
170170
if result.Limits == nil {
171171
result.Limits = corev1.ResourceList{}
172172
}
173-
if _, ok := result.Limits[resourceName]; !ok && !quantity.IsZero() {
174-
result.Limits[resourceName] = quantity
173+
if _, ok := result.Limits[resource]; !ok && !quantity.IsZero() {
174+
result.Limits[resource] = quantity
175175
}
176176
}
177177
// Set default requests if not present
178-
for resourceName, quantity := range defaults.Requests {
178+
for resource, quantity := range defaults.Requests {
179179
if result.Requests == nil {
180180
result.Requests = corev1.ResourceList{}
181181
}
182-
if _, ok := result.Requests[resourceName]; !ok && !quantity.IsZero() {
183-
result.Requests[resourceName] = quantity
182+
if _, ok := result.Requests[resource]; !ok && !quantity.IsZero() {
183+
result.Requests[resource] = quantity
184184
}
185185
}
186186

0 commit comments

Comments
 (0)