Merge pull request #594 from devforth/feature/AdminForth/1558/please-implement-codebase-to-m

fix: enhance URL handling in action configuration to support dynamic …

Author: SerVitasik

adminforth/documentation/docs/tutorial/03-Customization/09-Actions.md

@@ -190,15 +190,15 @@ Example to generate dynamic URL:
 {
   name: 'View on Google',
   icon: 'flowbite:external-link-solid',
-  url: async ({record, adminuser}) => `https://google.com/search?q=Apartment ${record.title}`,
+  url: async ({record, recordId, adminUser, resource }) => `https://google.com/search?q=Apartment ${record.title}`,
   showIn: {
     list: true,
     showButton: true
   }
 }
 ```
 
-> ☝️ Note: Though url function might be async we recommend to omit long awaits, or ideally don't use them at all, cause slow execution of this hoock might be a subject of bottleneck for resource pages rendering. For bult actions the async functions would be called in parallel to optimize loading speed.
+> ☝️ Note: Though url function might be async we recommend to omit long awaits, or ideally don't use them at all, cause slow execution of this hook might be a subject of bottleneck for resource pages rendering. For built actions the async functions would be called in parallel to optimize loading speed.
 
 
 ### Deep-level redirects.
@@ -207,14 +207,14 @@ Using `url` prop described above is recommended way to implementing URL navigati
 
 However, rearely you might also like to decide whether to redirect only after performing some logic (conditionally). This way is not recommended for most of cases, because it is not compatible with action native features (we can't know URL before executing action body):
 
-```
+
 ```ts
 {
   name: 'View on Google',
   icon: 'flowbite:external-link-solid',
   action: async ({ recordId }) => {
     if (await testSomething(recordId)) {
-        return { ok: true, redirectURL: 'https://google.com/search?q=apartment' };
+        return { ok: true, redirectUrl: 'https://google.com/search?q=apartment' };
     };
     return { ok: true, successMessage: 'Done' };
   },

adminforth/modules/restApi.ts

@@ -2238,6 +2238,11 @@ export default class AdminForthRestAPI implements IAdminForthRestAPI {
         if (!resource) {
           return { error: await tr(`Resource {resourceId} not found`, 'errors', { resourceId }) };
         }
+
+        const record = await this.adminforth.connectors[resource.dataSource].getRecordByPrimaryKey(resource, recordId);
+        if (!record){
+            return { error: `Record with ${recordId} not found` };
+        }
         const { allowedActions } = await interpretResource(
           adminUser, 
           resource, 
@@ -2257,16 +2262,18 @@ export default class AdminForthRestAPI implements IAdminForthRestAPI {
         }
 
         if (action.url) {
+          const redirectUrl = typeof action.url === 'function'
+            ? await action.url({ record, recordId, adminUser, resource })
+            : action.url;
           return {
             actionId,
             recordId,
+            record,
             resourceId,
-            redirectUrl: action.url
+            redirectUrl,
           }
         }
-
         const actionResponse = await action.action({ recordId, adminUser, resource, tr, adminforth: this.adminforth, response, extra: {...extra, cookies: cookies, headers: headers} });
-        
         return {
           actionId,
           recordId,

adminforth/types/Back.ts

@@ -1423,7 +1423,7 @@ export interface AdminForthActionInput {
     adminUser: AdminUser;
     standardAllowedActions: AllowedActions;
   }) => boolean | Promise<boolean>);
-  url?: string;
+  url?: string | ((params: { adminUser: AdminUser; resource: AdminForthResource; recordId: string, record: any }) => string);
   bulkHandler?: (params: {
       adminforth: IAdminForth;
       resource: AdminForthResource;