compiler: Add more checks prior to specialization

Author: EdCaunt

devito/ir/iet/visitors.py

@@ -1525,11 +1525,14 @@ def __init__(self, mapper, nested=False):
                                  f"specialization. Value {v} was supplied for symbol "
                                  f"{k}, but is of type {type(v)}.")
 
+            try:
+                _ = k.dtype(v)
+            except ValueError as e:
+                raise ValueError(f"Value {v} is incompatible with {k.dtype} dtype "
+                                 "of {k}") from e
+
     def _visit(self, o, *args, **kwargs):
         retval = super()._visit(o, *args, **kwargs)
-        # print(f"Visiting {o.__class__}")
-        # print(retval)
-        # print("--------------------------------------------")
         return retval
 
     # TODO: Should probably be moved to Uxreplace at least (as should some of these
@@ -1580,10 +1583,6 @@ def visit_Operator(self, o, **kwargs):
             raise ValueError(f"Attempted to specialize symbols {not_params} which are not"
                              " found in the Operator parameters")
 
-        # FIXME: Should also type-check the values supplied against the symbols they are
-        # replacing (and cast them if needed?) -> use a try-except on the cast in
-        # python-land
-
         parameters = tuple(i for i in o.parameters if i not in self.mapper)
 
         # Note: the following is not dissimilar to unpickling an Operator

tests/test_specialization.py

@@ -192,6 +192,8 @@ def test_apply_basic(self):
 
     # TODO: Need a test to check that block sizes can be specialized
     # TODO: Need to test that tile sizes can be specialized
+    # TODO: Test pickling followed by specialization
+    # TODO: Test specialized operators can be pickled
 
 
 class TestApply: