tests: Introduce further tests

Author: EdCaunt

devito/ir/iet/visitors.py

@@ -11,7 +11,7 @@
 import ctypes
 
 import cgen as c
-from sympy import IndexedBase
+from sympy import IndexedBase, Number
 from sympy.core.function import Application
 
 from devito.exceptions import CompilationError
@@ -1515,10 +1515,17 @@ def __init__(self, mapper, nested=False):
         super().__init__(mapper, nested=nested)
 
         # Sanity check
-        for k in self.mapper.keys():
+        for k, v in self.mapper.items():
+            # FIXME: Erronously blocks f_vec->size[1]
+            # Apparently this is an IndexedPointer
             if not isinstance(k, AbstractSymbol):
                 raise ValueError(f"Attempted to specialize non-scalar symbol: {k}")
 
+            if not isinstance(v, Number):
+                raise ValueError("Only SymPy Numbers can used to replace values during "
+                                 f"specialization. Value {v} was supplied for symbol "
+                                 f"{k}, but is of type {type(v)}.")
+
     def visit_Operator(self, o, **kwargs):
         # Entirely fine to apply this to an Operator (unlike Uxreplace) - indeed this
         # is the intended use case

tests/test_specialization.py

@@ -120,7 +120,8 @@ def define(self, dimensions):
         for m, o in zip(mappers, ops):
             check_op(m, o)
 
-    # FIXME: Currently throws an error
+    # FIXME: Currently throws an error - probably a missing handler for GuardFactor
+    # in Uxreplace
     # def test_factor(self):
     #     """Test that ConditionalDimensions can have their symbolic factors specialized"""
     #     size = 16
@@ -141,6 +142,28 @@ def define(self, dimensions):
     #     assert ci.symbolic_factor.name not in str(op1.ccode)
     #     assert "if ((i)%(4) == 0)" in str(op1.ccode)
 
-    # Spacings
+    def test_spacing(self):
+        """Test that grid spacings can be specialized"""
+        grid = Grid(shape=(11,))
+        f = Function(name='f', grid=grid)
+
+        op0 = Operator(Eq(f, f.dx))
+
+        mapper = {grid.dimensions[0].spacing: sympy.Float(grid.spacing[0])}
+        op1 = Specializer(mapper).visit(op0)
+
+        assert grid.dimensions[0].spacing not in op1.parameters
+        assert grid.dimensions[0].spacing.name not in str(op1.ccode)
+        assert "/1.0e-1F;" in str(op1.ccode)
 
     # Strides/sizes
+    def test_strides(self):
+        """Test that strides and sizes generated for linearization can be specialized"""
+        grid = Grid(shape=(11, 11))
+
+        f = TimeFunction(name='f', grid=grid, space_order=2)
+
+        op0 = Operator(Eq(f.forward, f.dx2),
+                       opt=('advanced', {'expand': True, 'linearize': True}))
+
+        from IPython import embed; embed()