Skip to content

Commit f8abdae

Browse files
committed
misc: Tweaks
1 parent 1dc1857 commit f8abdae

8 files changed

Lines changed: 19 additions & 25 deletions

File tree

.github/actions/docker-run/action.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,20 @@ inputs:
77
uid:
88
description: "Unique identifier output from docker-build action"
99
required: true
10+
tag:
11+
description: "Tag of the built image to use"
12+
required: true
13+
name:
14+
description: "Name substring for docker to use when running the command"
15+
default: ""
1016
args:
11-
description: "Arguments to pass to `docker run`"
17+
description: "Arguments to pass to `docker run`, `--init -t --rm` are always added"
1218
required: true
1319
default: ""
1420
env:
1521
description: "Environment variables to set inside the docker container, one environment variable per line"
1622
required: true
1723
default: ""
18-
tag:
19-
description: "Tag of the built image to use"
20-
required: true
21-
name:
22-
description: "Name for docker to use when running the command"
23-
default: ""
2424
command:
2525
description: "Command to execute inside of the docker container"
2626
required: true

.github/workflows/examples-mpi.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ concurrency:
1414
cancel-in-progress: true
1515

1616
on:
17-
# Trigger the workflow on push or pull request,
18-
# but only for the main branch
17+
# Trigger the workflow on push or pull request, but only for the main branch
1918
push:
2019
branches:
2120
- main

.github/workflows/examples.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ concurrency:
88
cancel-in-progress: true
99

1010
on:
11-
# Trigger the workflow on push or pull request,
12-
# but only for the main branch
11+
# Trigger the workflow on push or pull request, but only for the main branch
1312
push:
1413
branches:
1514
- main
@@ -32,7 +31,7 @@ jobs:
3231
DEVITO_LANGUAGE: "openmp"
3332

3433
strategy:
35-
# Prevent all build to stop if a single one fails
34+
# Prevent cancellation if a single workflow fails
3635
fail-fast: false
3736

3837
steps:

.github/workflows/lint.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@ concurrency:
77
cancel-in-progress: true
88

99
on:
10-
# Trigger the workflow on push or pull request,
11-
# but only for the main branch
10+
# Trigger the workflow on push or pull request, but only for the main branch
1211
push:
1312
branches:
1413
- main

.github/workflows/pytest-core-mpi.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ concurrency:
88
cancel-in-progress: true
99

1010
on:
11-
# Trigger the workflow on push or pull request,
12-
# but only for the main branch
11+
# Trigger the workflow on push or pull request, but only for the main branch
1312
push:
1413
branches:
1514
- main

.github/workflows/pytest-core-nompi.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ concurrency:
88
cancel-in-progress: true
99

1010
on:
11-
# Trigger the workflow on push or pull request,
12-
# but only for the main branch
11+
# Trigger the workflow on push or pull request, but only for the main branch
1312
push:
1413
branches:
1514
- main
@@ -28,7 +27,7 @@ jobs:
2827
OMP_NUM_THREADS: 2
2928

3029
strategy:
31-
# Prevent all build to stop if a single one fails
30+
# Prevent cancellation if a single workflow fails
3231
fail-fast: false
3332

3433
matrix:
@@ -185,7 +184,7 @@ jobs:
185184
OMP_NUM_THREADS: 2
186185

187186
strategy:
188-
# Prevent all build to stop if a single one fails
187+
# Prevent cancellation if a single workflow fails
189188
fail-fast: false
190189

191190
matrix:

.github/workflows/pytest-gpu.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
runner_label: amdgpu
5757
base: "devitocodes/bases:amd"
5858
test_drive_cmd: "rocm-smi"
59-
# Unchanged, still passes through required /dev nodes etc.
59+
# Passes through required /dev nodes etc.
6060
dockerflags: >-
6161
--network=host
6262
--device=/dev/kfd --device=/dev/dri

.github/workflows/tutorials.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ concurrency:
88
cancel-in-progress: true
99

1010
on:
11-
# Trigger the workflow on push or pull request,
12-
# but only for the main branch
11+
# Trigger the workflow on push or pull request, but only for the main branch
1312
push:
1413
branches:
1514
- main
@@ -27,7 +26,7 @@ jobs:
2726
DEVITO_LANGUAGE: ${{ matrix.language }}
2827

2928
strategy:
30-
# Prevent all build to stop if a single one fails
29+
# Prevent cancellation if a single workflow fails
3130
fail-fast: false
3231
matrix:
3332
name: [
@@ -124,7 +123,7 @@ jobs:
124123
DEVITO_LANGUAGE: ${{ matrix.language }}
125124

126125
strategy:
127-
# Prevent all build to stop if a single one fails
126+
# Prevent cancellation if a single workflow fails
128127
fail-fast: false
129128
matrix:
130129
name: [

0 commit comments

Comments
 (0)