fix(review): address PR #264 review feedback

- Rename DevLoginAutoConfiguration → DevLoginConfiguration and
  WebAuthnAutoConfiguration → WebAuthnConfiguration to avoid implying
  Spring Boot SPI semantics (these are component-scanned, not
  SPI-registered via AutoConfiguration.imports)
- Remove @propertysource from DevLoginConfiguration: the annotation
  cannot influence its own @ConditionalOnProperty evaluation (condition
  is checked before @propertysource is processed), and defaults are
  already available via WebAuthnConfiguration which unconditionally
  loads dsspringuserconfig.properties

Author: devondragon

…/user/dev/DevLoginAutoConfiguration.java …ring/user/dev/DevLoginConfiguration.javasrc/main/java/com/digitalsanctuary/spring/user/dev/DevLoginAutoConfiguration.java renamed to src/main/java/com/digitalsanctuary/spring/user/dev/DevLoginConfiguration.java src/main/java/com/digitalsanctuary/spring/user/dev/DevLoginAutoConfiguration.java renamed to src/main/java/com/digitalsanctuary/spring/user/dev/DevLoginConfiguration.java

@@ -4,21 +4,24 @@
 import org.springframework.boot.context.properties.EnableConfigurationProperties;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Profile;
-import org.springframework.context.annotation.PropertySource;
 
 /**
- * Auto-configuration for the dev login feature.
+ * Configuration that registers {@link DevLoginConfigProperties}.
  * <p>
  * Activates only when the {@code local} profile is active and
  * {@code user.dev.auto-login-enabled=true}. Individual dev-login components
  * ({@link DevLoginController}, {@link DevLoginStartupWarning}) carry their own
  * guards for defense-in-depth.
  * </p>
+ * <p>
+ * Note: this class is registered via component scan (not Spring Boot SPI), so
+ * default property values are provided by {@code WebAuthnConfiguration}, which
+ * unconditionally loads {@code classpath:config/dsspringuserconfig.properties}.
+ * </p>
  */
 @Configuration
 @Profile("local")
 @ConditionalOnProperty(name = "user.dev.auto-login-enabled", havingValue = "true", matchIfMissing = false)
-@PropertySource("classpath:config/dsspringuserconfig.properties")
 @EnableConfigurationProperties(DevLoginConfigProperties.class)
-public class DevLoginAutoConfiguration {
+public class DevLoginConfiguration {
 }

…/security/WebAuthnAutoConfiguration.java …user/security/WebAuthnConfiguration.javasrc/main/java/com/digitalsanctuary/spring/user/security/WebAuthnAutoConfiguration.java renamed to src/main/java/com/digitalsanctuary/spring/user/security/WebAuthnConfiguration.java src/main/java/com/digitalsanctuary/spring/user/security/WebAuthnAutoConfiguration.java renamed to src/main/java/com/digitalsanctuary/spring/user/security/WebAuthnConfiguration.java

@@ -5,7 +5,7 @@
 import org.springframework.context.annotation.PropertySource;
 
 /**
- * Auto-configuration that registers {@link WebAuthnConfigProperties}.
+ * Configuration that registers {@link WebAuthnConfigProperties}.
  * <p>
  * This configuration is always active because {@code WebSecurityConfig} requires
  * {@link WebAuthnConfigProperties} regardless of whether WebAuthn is enabled.
@@ -16,5 +16,5 @@
 @Configuration
 @PropertySource("classpath:config/dsspringuserconfig.properties")
 @EnableConfigurationProperties(WebAuthnConfigProperties.class)
-public class WebAuthnAutoConfiguration {
+public class WebAuthnConfiguration {
 }