Skip to content

Commit e5368c0

Browse files
committed
first part of review remakrs
1 parent 96ea2d0 commit e5368c0

4 files changed

Lines changed: 5 additions & 4 deletions

File tree

modules/ROOT/pages/cross_cutting/test_automation/architecture_tests.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Naming convention test::
1212
+
1313
--
1414
[source, java]
15-
@AnalyzeClasses(packages = "com.capgemini.component")
15+
@AnalyzeClasses(packages = "com.myapp.component")
1616
public class NamingRuleTest {
1717
@ArchTest
1818
static ArchRule entities_named_correctly =
@@ -32,7 +32,7 @@ Layered Architecture Test::
3232
--
3333
[source, java]
3434

35-
@AnalyzeClasses(packages = "com.capgemini.component")
35+
@AnalyzeClasses(packages = "com.myapp.component")
3636
public class DependencyRuleTest {
3737
@ArchTest
3838
static ArchRule layered_architecture_check =

modules/ROOT/pages/cross_cutting/test_automation/sub_system_tests.adoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ Web development often works with libraries or patterns of re-usable UI component
292292
They change over time.
293293
Like the motivation for the page object pattern, you don't want to change all tests or all page objects, if the internal structure of such a component changes.
294294
So, similar to page objects, create "widget objects" that encapsulate the access to common UI components.
295+
These widget objects are then used in page objects.
295296

296297
If you use Selenium, you need to expect https://www.baeldung.com/selenium-staleelementreferenceexception[StaleElementReferenceExceptions].
297298
So, you should not save a reference to a WebElement in your widget object.

modules/ROOT/pages/cross_cutting/test_automation/test_automation.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ not more than one class;
1414
all other classes mocked;
1515
especially no access to database.
1616
* *(Unit-Integration-Tests)*:
17-
closely rated units are tested together;
17+
closely related units are tested together;
1818
outside scope mocked;
1919
no access to database;
2020
often not considered as an extra level, but as part of Unit-Tests.

modules/ROOT/pages/cross_cutting/test_automation/unit_tests.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This articles focuses on Unit- and Unit-Integration-Tests.
55
General test automation good practices can be found xref:cross_cutting/test_automation/test_automation.adoc[here].
66

77
=== Use TDD to improve code and test quality
8-
https://testdriven.io/test-driven-development/[Test Driven Development (TDD)] is a software development method where tests are written first before the actual code.
8+
https://testdriven.io/test-driven-development/[Test Driven Development (TDD)] is a software development method where tests are written first before the actual code in cycles "make it red, make it green, make it clean".
99
It leads to better tests and often to a better design, because the parts where the logic happens are better structured to allow easy testing.
1010
It also leads to better code, because the last step is a refactoring that can be performed safely because of the tests.
1111

0 commit comments

Comments
 (0)