Skip to content

Commit 3e8d29d

Browse files
authored
Merge pull request #591 from DevBrent/patch-1
Typo showNewMessage not showNewMessages
2 parents 0da9211 + 801485d commit 3e8d29d

5 files changed

Lines changed: 16 additions & 16 deletions

File tree

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ Used to retrieve all methods bundled with Intercom. These are based on the offic
129129
| hide | () => void | hides the Messenger, will call `onHide` if supplied to `IntercomProvider` |
130130
| show | () => void | shows the Messenger, will call `onShow` if supplied to `IntercomProvider` |
131131
| showMessages | () => void | shows the Messenger with the message list |
132-
| showNewMessages | (content?: string) => void | shows the Messenger as if a new conversation was just created. If `content` is passed, it will fill in the message composer |
132+
| showNewMessage | (content?: string) => void | shows the Messenger as if a new conversation was just created. If `content` is passed, it will fill in the message composer |
133133
| getVisitorId | () => string | gets the visitor id |
134134
| startTour | (tourId: number) => void | starts a tour based on the `tourId` |
135135
| trackEvent | (event: string, metaData?: object) => void | submits an `event` with optional `metaData`
@@ -158,7 +158,7 @@ const HomePage = () => {
158158
hide,
159159
show,
160160
showMessages,
161-
showNewMessages,
161+
showNewMessage,
162162
getVisitorId,
163163
startTour,
164164
trackEvent,
@@ -167,8 +167,8 @@ const HomePage = () => {
167167

168168
const bootWithProps = () => boot({ name: 'Russo' });
169169
const updateWithProps = () => update({ name: 'Ossur' });
170-
const handleNewMessages = () => showNewMessages();
171-
const handleNewMessagesWithContent = () => showNewMessages('content');
170+
const handleNewMessages = () => showNewMessage();
171+
const handleNewMessagesWithContent = () => showNewMessage('content');
172172
const handleGetVisitorId = () => console.log(getVisitorId());
173173
const handleStartTour = () => startTour(123);
174174
const handleTrackEvent = () => trackEvent('invited-friend');

cypress/integration/show.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ describe('showMessages', () => {
2525
});
2626
});
2727

28-
describe('showNewMessages', () => {
29-
it('should show new message `showNewMessages`', () => {
28+
describe('showNewMessage', () => {
29+
it('should show new message `showNewMessage`', () => {
3030
cy.visit('/useIntercom');
3131

3232
cy.get('[data-cy=boot]').click();
@@ -38,7 +38,7 @@ describe('showNewMessages', () => {
3838
.should('exist');
3939
});
4040

41-
it('should show new message with content when calling `showNewMessages`', () => {
41+
it('should show new message with content when calling `showNewMessage`', () => {
4242
cy.visit('/useIntercom');
4343

4444
cy.get('[data-cy=boot]').click();

playground/modules/useIntercom/useIntercom.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ const RawUseIntercomPage = () => {
3131
hide,
3232
show,
3333
showMessages,
34-
showNewMessages,
34+
showNewMessage,
3535
getVisitorId,
3636
trackEvent,
3737
showArticle,
@@ -111,13 +111,13 @@ const RawUseIntercomPage = () => {
111111
update({ name: 'ponas' });
112112
}, [update]);
113113

114-
const handleNewMessages = React.useCallback(() => showNewMessages(), [
115-
showNewMessages,
114+
const handleNewMessages = React.useCallback(() => showNewMessage(), [
115+
showNewMessage,
116116
]);
117117

118118
const handleNewMessagesWithContent = React.useCallback(
119-
() => showNewMessages('pre-definded-content'),
120-
[showNewMessages],
119+
() => showNewMessage('pre-definded-content'),
120+
[showNewMessage],
121121
);
122122

123123
const handleGetVisitorId = React.useCallback(() => {

src/provider.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export const IntercomProvider: React.FC<React.PropsWithChildren<
186186
});
187187
}, [ensureIntercom]);
188188

189-
const showNewMessages = React.useCallback(
189+
const showNewMessage = React.useCallback(
190190
(message?: string) => {
191191
ensureIntercom('showNewMessage', () => {
192192
if (!message) {
@@ -245,7 +245,7 @@ export const IntercomProvider: React.FC<React.PropsWithChildren<
245245
show,
246246
isOpen,
247247
showMessages,
248-
showNewMessages,
248+
showNewMessage,
249249
getVisitorId,
250250
startTour,
251251
trackEvent,
@@ -260,7 +260,7 @@ export const IntercomProvider: React.FC<React.PropsWithChildren<
260260
show,
261261
isOpen,
262262
showMessages,
263-
showNewMessages,
263+
showNewMessage,
264264
getVisitorId,
265265
startTour,
266266
trackEvent,

src/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ export type IntercomContextValues = {
338338
* showMessages('pre-populated-content');
339339
* ```
340340
*/
341-
showNewMessages: (prePopulatedContent?: string) => void;
341+
showNewMessage: (prePopulatedContent?: string) => void;
342342
/**
343343
* A visitor is someone who goes to your site but does not use the messenger.
344344
* You can track these visitors via the visitor `user_id`.

0 commit comments

Comments
 (0)